Fixed ScamDetector ignoring untrusted users and firing against trusted (#1287)

Zabuzard · web-flow · commit 7b5dbb1c2420 · 2025-07-29T09:08:49.000+02:00
diff --git a/application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetector.java b/application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetector.java
@@ -53,7 +53,7 @@ public ScamDetector(Config config) {
     public boolean isScam(Message message) {
         Member author = message.getMember();
         boolean isTrustedUser = author != null
-                && author.getRoles().stream().map(Role::getName).noneMatch(hasTrustedRole);
+                && author.getRoles().stream().map(Role::getName).anyMatch(hasTrustedRole);
         if (isTrustedUser) {
             return false;
         }
diff --git a/application/src/test/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetectorTest.java b/application/src/test/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetectorTest.java
@@ -223,7 +223,7 @@ void ignoreTrustedUser() {
         boolean isScamResult = scamDetector.isScam(message);
 
         // THEN flags it as harmless
-        assertTrue(isScamResult);
+        assertFalse(isScamResult);
     }
 
     private static Message createMessageMock(String content, List<Message.Attachment> attachments) {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public ScamDetector(Config config) {`
`53`	`53`	`public boolean isScam(Message message) {`
`54`	`54`	`Member author = message.getMember();`
`55`	`55`	`boolean isTrustedUser = author != null`
`56`		`- && author.getRoles().stream().map(Role::getName).noneMatch(hasTrustedRole);`
	`56`	`+ && author.getRoles().stream().map(Role::getName).anyMatch(hasTrustedRole);`
`57`	`57`	`if (isTrustedUser) {`
`58`	`58`	`return false;`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ void ignoreTrustedUser() {`
`223`	`223`	`boolean isScamResult = scamDetector.isScam(message);`
`224`	`224`
`225`	`225`	`// THEN flags it as harmless`
`226`		`- assertTrue(isScamResult);`
	`226`	`+ assertFalse(isScamResult);`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`private static Message createMessageMock(String content, List<Message.Attachment> attachments) {`