fix: improve role refresh handling and make it work

Author: christolis

application/src/main/java/org/togetherjava/tjbot/Application.java

@@ -5,8 +5,6 @@
 import net.dv8tion.jda.api.events.interaction.command.SlashCommandInteractionEvent;
 import net.dv8tion.jda.api.exceptions.InvalidTokenException;
 import net.dv8tion.jda.api.requests.GatewayIntent;
-import net.dv8tion.jda.api.utils.ChunkingFilter;
-import net.dv8tion.jda.api.utils.MemberCachePolicy;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -85,8 +83,6 @@ public static void runBot(Config config) {
             Database database = new Database("jdbc:sqlite:" + databasePath.toAbsolutePath());
 
             JDA jda = JDABuilder.createDefault(config.getToken())
-                .setChunkingFilter(ChunkingFilter.ALL)
-                .setMemberCachePolicy(MemberCachePolicy.ALL)
                 .enableIntents(GatewayIntent.GUILD_MEMBERS, GatewayIntent.MESSAGE_CONTENT)
                 .build();
 

application/src/main/java/org/togetherjava/tjbot/features/Features.java

@@ -15,7 +15,9 @@
 import org.togetherjava.tjbot.features.bookmarks.BookmarksSystem;
 import org.togetherjava.tjbot.features.bookmarks.LeftoverBookmarksCleanupRoutine;
 import org.togetherjava.tjbot.features.bookmarks.LeftoverBookmarksListener;
+import org.togetherjava.tjbot.features.cakeday.CakeDayListener;
 import org.togetherjava.tjbot.features.cakeday.CakeDayRoutine;
+import org.togetherjava.tjbot.features.cakeday.CakeDayService;
 import org.togetherjava.tjbot.features.chatgpt.ChatGptCommand;
 import org.togetherjava.tjbot.features.chatgpt.ChatGptService;
 import org.togetherjava.tjbot.features.code.CodeMessageAutoDetection;
@@ -116,6 +118,7 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
                 new CodeMessageHandler(blacklistConfig.special(), jshellEval);
         ChatGptService chatGptService = new ChatGptService(config);
         HelpSystemHelper helpSystemHelper = new HelpSystemHelper(config, database, chatGptService);
+        CakeDayService cakeDayService = new CakeDayService(config, database);
         HelpThreadLifecycleListener helpThreadLifecycleListener =
                 new HelpThreadLifecycleListener(helpSystemHelper, database);
 
@@ -136,7 +139,7 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
         features.add(new LeftoverBookmarksCleanupRoutine(bookmarksSystem));
         features.add(new MarkHelpThreadCloseInDBRoutine(database, helpThreadLifecycleListener));
         features.add(new MemberCountDisplayRoutine(config));
-        features.add(new CakeDayRoutine(config, database));
+        features.add(new CakeDayRoutine(cakeDayService));
         features.add(new RSSHandlerRoutine(config, database));
 
         // Message receivers
@@ -158,6 +161,7 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
         features.add(new GuildLeaveCloseThreadListener(config));
         features.add(new LeftoverBookmarksListener(bookmarksSystem));
         features.add(new HelpThreadCreatedListener(helpSystemHelper));
+        features.add(new CakeDayListener(cakeDayService));
         features.add(new HelpThreadLifecycleListener(helpSystemHelper, database));
 
         // Message context commands

application/src/main/java/org/togetherjava/tjbot/features/cakeday/CakeDayListener.java

@@ -0,0 +1,84 @@
+package org.togetherjava.tjbot.features.cakeday;
+
+import net.dv8tion.jda.api.entities.Guild;
+import net.dv8tion.jda.api.entities.Member;
+import net.dv8tion.jda.api.entities.User;
+import net.dv8tion.jda.api.events.guild.member.GuildMemberRemoveEvent;
+import net.dv8tion.jda.api.events.message.MessageReceivedEvent;
+import net.dv8tion.jda.api.hooks.ListenerAdapter;
+import org.jetbrains.annotations.NotNull;
+
+import org.togetherjava.tjbot.db.generated.tables.records.CakeDaysRecord;
+import org.togetherjava.tjbot.features.EventReceiver;
+
+import java.util.Optional;
+
+/**
+ * A listener class responsible for handling cake day related events.
+ */
+public class CakeDayListener extends ListenerAdapter implements EventReceiver {
+
+    private final CakeDayService cakeDayService;
+
+    /**
+     * Constructs a new CakeDayListener with the given {@link CakeDayService}.
+     *
+     * @param cakeDayService the {@link CakeDayService} to be used by this listener
+     */
+    public CakeDayListener(CakeDayService cakeDayService) {
+        this.cakeDayService = cakeDayService;
+    }
+
+    /**
+     * Handles the event of a message being received in a guild.
+     * <p>
+     * It caches the user's cake day and inserts the member's cake day into the database if not
+     * already present.
+     *
+     * @param event the {@link MessageReceivedEvent} representing the message received
+     */
+    @Override
+    public void onMessageReceived(@NotNull MessageReceivedEvent event) {
+        User author = event.getAuthor();
+        Member member = event.getMember();
+        long authorId = author.getIdLong();
+        long guildId = event.getGuild().getIdLong();
+
+        if (member == null || author.isBot() || author.isSystem()) {
+            return;
+        }
+
+
+        if (cakeDayService.hasMemberCakeDayToday(member)) {
+            cakeDayService.addCakeDayRole(member);
+            return;
+        }
+
+        if (cakeDayService.isUserCached(author)) {
+            return;
+        }
+
+        cakeDayService.addToCache(author);
+        Optional<CakeDaysRecord> cakeDaysRecord =
+                cakeDayService.findUserCakeDayFromDatabase(authorId);
+        if (cakeDaysRecord.isPresent()) {
+            return;
+        }
+
+        cakeDayService.insertMemberCakeDayToDatabase(member, guildId);
+    }
+
+    /**
+     * Handles the event of a guild member being removed from the guild. It removes the user's cake
+     * day information from the database if present.
+     *
+     * @param event the {@link GuildMemberRemoveEvent} representing the member removal event
+     */
+    @Override
+    public void onGuildMemberRemove(GuildMemberRemoveEvent event) {
+        User user = event.getUser();
+        Guild guild = event.getGuild();
+
+        cakeDayService.handleUserLeft(user, guild);
+    }
+}