application-create: hardcode certain config values

Certain configuration values pertaining to the application form creating
and handling for custom roles do not need to be there and are deemed
more appropriate as hardcoded values inside the code itself.

Remove the configuration entries from the `config.json.template` as well
as references to such keys in the codebase and introduce them as static
constants in the appropriate class files.

Suggested-by: Zabuzard <zabuza.dev@gmail.com>
Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

Author: christolis

application/config.json.template

@@ -177,10 +177,7 @@
     },
     "roleApplicationSystem": {
         "submissionsChannelPattern": "staff-applications",
-        "defaultQuestion": "What makes you a good addition to the team?",
-        "minimumAnswerLength": 50,
-        "maximumAnswerLength": 500,
-        "applicationSubmitCooldownMinutes": 5
+        "defaultQuestion": "What makes you a good addition to the team?"
     },
     "memberCountCategoryPattern": "Info"
 }

application/src/main/java/org/togetherjava/tjbot/config/RoleApplicationSystemConfig.java

@@ -12,19 +12,11 @@
  * @param submissionsChannelPattern the pattern used to identify the submissions channel where
  *        applications are sent
  * @param defaultQuestion the default question that will be asked in the role application form
- * @param minimumAnswerLength the minimum number of characters required for the applicant's answer
- * @param maximumAnswerLength the maximum number of characters allowed for the applicant's answer
- * @param applicationSubmitCooldownMinutes the cooldown time in minutes before the user can submit
- *        another application
  */
 public record RoleApplicationSystemConfig(
         @JsonProperty(value = "submissionsChannelPattern",
                 required = true) String submissionsChannelPattern,
-        @JsonProperty(value = "defaultQuestion", required = true) String defaultQuestion,
-        @JsonProperty(value = "minimumAnswerLength", required = true) int minimumAnswerLength,
-        @JsonProperty(value = "maximumAnswerLength", required = true) int maximumAnswerLength,
-        @JsonProperty(value = "applicationSubmitCooldownMinutes",
-                required = true) int applicationSubmitCooldownMinutes) {
+        @JsonProperty(value = "defaultQuestion", required = true) String defaultQuestion) {
 
     /**
      * Constructs an instance of {@link RoleApplicationSystemConfig} with the provided parameters.

application/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

@@ -29,6 +29,8 @@
  * users to prevent spamming.
  */
 public class ApplicationApplyHandler {
+    private static final int APPLICATION_SUBMIT_COOLDOWN_MINUTES = 5;
+
     private final Cache<Member, OffsetDateTime> applicationSubmitCooldown;
     private final Predicate<String> applicationChannelPattern;
     private final RoleApplicationSystemConfig roleApplicationSystemConfig;
@@ -46,7 +48,7 @@ public ApplicationApplyHandler(RoleApplicationSystemConfig roleApplicationSystem
                     .asMatchPredicate();
 
         final Duration applicationSubmitCooldownDuration =
-                Duration.ofMinutes(roleApplicationSystemConfig.applicationSubmitCooldownMinutes());
+                Duration.ofMinutes(APPLICATION_SUBMIT_COOLDOWN_MINUTES);
         applicationSubmitCooldown =
                 Caffeine.newBuilder().expireAfterWrite(applicationSubmitCooldownDuration).build();
     }
@@ -134,8 +136,7 @@ protected long getMemberCooldownMinutes(Member member) {
         OffsetDateTime timeSentCache = getApplicationSubmitCooldown().getIfPresent(member);
         if (timeSentCache != null) {
             Duration duration = Duration.between(timeSentCache, OffsetDateTime.now());
-            return roleApplicationSystemConfig.applicationSubmitCooldownMinutes()
-                    - duration.toMinutes();
+            return APPLICATION_SUBMIT_COOLDOWN_MINUTES - duration.toMinutes();
         }
         return 0L;
     }

application/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

@@ -47,6 +47,8 @@ public class ApplicationCreateCommand extends SlashCommandAdapter {
     private static final String ROLE_COMPONENT_ID_HEADER = "application-create";
     private static final String VALUE_DELIMITER = "_";
     private static final int ARG_COUNT = 3;
+    private static final int MINIMUM_ANSWER_LENGTH = 50;
+    private static final int MAXIMUM_ANSWER_LENGTH = 500;
 
     private final ApplicationApplyHandler applicationApplyHandler;
     private final RoleApplicationSystemConfig roleApplicationSystemConfig;
@@ -136,8 +138,7 @@ public void onStringSelectSelection(StringSelectInteractionEvent event, List<Str
             .create(generateComponentId(event.getUser().getId()),
                     roleApplicationSystemConfig.defaultQuestion(), TextInputStyle.PARAGRAPH)
             .setRequired(true)
-            .setRequiredRange(roleApplicationSystemConfig.minimumAnswerLength(),
-                    roleApplicationSystemConfig.maximumAnswerLength())
+            .setRequiredRange(MINIMUM_ANSWER_LENGTH, MAXIMUM_ANSWER_LENGTH)
             .setPlaceholder("Enter your answer here")
             .build();