Implement Clone for String

Author: TimDiekmann

src/string.rs

@@ -80,7 +80,7 @@ use core::{
 #[cfg(feature = "std")]
 use std::borrow::Cow;
 
-use crate::alloc::handle_alloc_error;
+use crate::{alloc::handle_alloc_error, clone::CloneIn};
 pub use liballoc::string::{ParseError, ToString};
 
 /// A UTF-8 encoded, growable string.
@@ -1991,8 +1991,13 @@ impl fmt::Display for FromUtf16Error {
     }
 }
 
-impl Clone for String {
-    #[must_use]
+impl<A> Clone for String<A>
+where
+    A: AllocRef,
+    A::BuildAlloc: Clone,
+{
+    #[inline]
+    #[must_use = "Cloning is expected to be expensive"]
     fn clone(&self) -> Self {
         Self {
             vec: self.vec.clone(),
@@ -2004,6 +2009,26 @@ impl Clone for String {
     }
 }
 
+#[allow(clippy::use_self)]
+impl<A: AllocRef, B: AllocRef> CloneIn<B> for String<A> {
+    type Cloned = String<B>;
+
+    #[inline]
+    #[must_use = "Cloning is expected to be expensive"]
+    fn clone_in(&self, a: B) -> Self::Cloned {
+        String {
+            vec: self.vec.clone_in(a),
+        }
+    }
+
+    #[inline]
+    fn try_clone_in(&self, a: B) -> Result<Self::Cloned, B::Error> {
+        Ok(String {
+            vec: self.vec.try_clone_in(a)?,
+        })
+    }
+}
+
 impl FromIterator<char> for String {
     fn from_iter<I: IntoIterator<Item = char>>(iter: I) -> Self {
         let mut buf = Self::new();

src/vec.rs

@@ -69,15 +69,7 @@
 //! [`vec!`]: ../macro.vec.html
 
 use crate::{
-    alloc::{
-        handle_alloc_error,
-        AllocRef,
-        BuildAllocRef,
-        DeallocRef,
-        Global,
-        NonZeroLayout,
-        ReallocRef,
-    },
+    alloc::{handle_alloc_error, AllocRef, BuildAllocRef, DeallocRef, Global, ReallocRef},
     boxed::Box,
     clone::CloneIn,
     collections::CollectionAllocErr,