fix: fetch user roles before update

Author: Throyer

src/main/java/com/github/throyer/common/springboot/domain/user/repository/UserRepository.java

@@ -12,6 +12,7 @@
 public interface UserRepository {
     Page<User> findAll(Pageable pageable);
     Optional<User> findById(Long id);
+    Optional<User> findByIdFetchRoles(Long id);
     Optional<User> findByEmail(String email);
     Boolean existsByEmail(String email);
     void deleteById(Long id);

src/main/java/com/github/throyer/common/springboot/domain/user/repository/UserRepositoryImpl.java

@@ -36,6 +36,11 @@ public Optional<User> findById(Long id) {
         return queryNative.findById(id);
     }
 
+    @Override
+    public Optional<User> findByIdFetchRoles(Long id) {
+        return this.springData.findByIdFetchRoles(id);
+    }
+
     @Override
     public Optional<User> findByEmail(String email) {
         return queryNative.findByEmail(email);

src/main/java/com/github/throyer/common/springboot/domain/user/repository/springdata/SpringDataUserRepository.java

@@ -34,5 +34,10 @@ default void deleteAll(Iterable<? extends User> entities) {
 
     Boolean existsByEmail(String email);
 
-    Optional<User> findOptionalByEmail(String email);
+    @Query("""
+        select user from #{#entityName} user
+        left join fetch user.roles
+        where user.id = ?1 
+    """)
+    Optional<User> findByIdFetchRoles(Long id);
 }

src/main/java/com/github/throyer/common/springboot/domain/user/service/UpdateUserService.java

@@ -28,7 +28,7 @@ public User update(Long id, UpdateUserProps body) {
                 .orElseThrow(() -> unauthorized(message(NOT_AUTHORIZED_TO_MODIFY, "'user'")));
 
         var actual = repository
-            .findById(id)
+            .findByIdFetchRoles(id)
                 .orElseThrow(() -> notFound("User not found"));
 
         validateEmailUniquenessOnModify(body, actual);