Fix deserialization abort and not logging datagram handling errors (ThinkParQ/beegfs-rs#183)

Author: rustybee42

shared/src/bee_serde.rs

@@ -338,7 +338,9 @@ impl<'a> Deserializer<'a> {
 
         let len = self.u32()? as usize;
 
-        let mut v = Vec::with_capacity(len);
+        let mut v = Vec::new();
+        v.try_reserve_exact(len)?;
+
         for _ in 0..len {
             v.push(f(self)?);
         }
@@ -371,7 +373,9 @@ impl<'a> Deserializer<'a> {
 
         let len = self.u32()? as usize;
 
-        let mut v = HashMap::with_capacity(len);
+        let mut v = HashMap::new();
+        v.try_reserve(len)?;
+
         for _ in 0..len {
             v.insert(f_key(self)?, f_value(self)?);
         }

shared/src/conn/incoming.rs

@@ -118,7 +118,10 @@ async fn stream_loop(
                 }
             }
 
-            log::error!("Closed stream from {:?}: {err:#}", stream.addr());
+            log::error!(
+                "Error while handling stream from {:?}: {err:#}",
+                stream.addr()
+            );
             return;
         }
     }
@@ -143,8 +146,8 @@ async fn read_stream(
         && buf.msg_id() != AuthenticateChannel::ID
     {
         bail!(
-            "Received message on unauthenticated stream from {:?}",
-            stream.addr()
+            "Stream is not authenticated and received message with id {}",
+            buf.msg_id()
         );
     }
 
@@ -220,7 +223,9 @@ async fn recv_datagram(sock: Arc<UdpSocket>, msg_handler: impl DispatchRequest)
         };
 
         // Forward to the dispatcher
-        let _ = msg_handler.dispatch_request(req).await;
+        if let Err(err) = msg_handler.dispatch_request(req).await {
+            log::error!("Error while handling datagram from {peer_addr:?}: {err:#}");
+        }
     });
 
     Ok(())