Fix for MysqliDb usage with HHVM

avbdr · avbdr · commit 41778490e3f4 · 2015-08-04T07:15:55.000Z
diff --git a/MysqliDb.php b/MysqliDb.php
@@ -1105,9 +1105,11 @@ public function __destruct()
      *
      * @return array
      */
-    protected function refValues($arr)
+    protected function refValues(Array &$arr)
     {
-        //Reference is required for PHP 5.3+
+        //Reference in the function arguments are required for HHVM to work
+        //https://github.com/facebook/hhvm/issues/5155
+        //Referenced data array is required by mysqli since PHP 5.3+
         if (strnatcmp(phpversion(), '5.3') >= 0) {
             $refs = array();
             foreach ($arr as $key => $value) {

Original file line number	Diff line number	Diff line change
`@@ -1105,9 +1105,11 @@ public function __destruct()`
`1105`	`1105`	`*`
`1106`	`1106`	`* @return array`
`1107`	`1107`	`*/`
`1108`		`- protected function refValues($arr)`
	`1108`	`+ protected function refValues(Array &$arr)`
`1109`	`1109`	`{`
`1110`		`- //Reference is required for PHP 5.3+`
	`1110`	`+ //Reference in the function arguments are required for HHVM to work`
	`1111`	`+ //https://github.com/facebook/hhvm/issues/5155`
	`1112`	`+ //Referenced data array is required by mysqli since PHP 5.3+`
`1111`	`1113`	`if (strnatcmp(phpversion(), '5.3') >= 0) {`
`1112`	`1114`	`$refs = array();`
`1113`	`1115`	`foreach ($arr as $key => $value) {`