Merge pull request #112 from TheDragonCode/4.x-1

Refactored `actions:upgrade` console command

Author: andrey-helldar

src/Console/Upgrade.php

@@ -12,7 +12,7 @@ class Upgrade extends Command
 {
     protected $name = Names::UPGRADE;
 
-    protected $description = 'Action structure upgrade from version 2 to 3';
+    protected $description = 'Action project upgrade from version 3 to 4';
 
     protected Processor|string $processor = UpgradeProcessor::class;
 }

src/Processors/Upgrade.php

@@ -4,171 +4,99 @@
 
 namespace DragonCode\LaravelActions\Processors;
 
+use Closure;
 use DragonCode\LaravelActions\Concerns\Anonymous;
-use DragonCode\LaravelActions\ServiceProvider;
-use DragonCode\Support\Facades\Filesystem\Directory;
+use DragonCode\LaravelActions\Constants\Names;
 use DragonCode\Support\Facades\Filesystem\File;
 use DragonCode\Support\Facades\Helpers\Str;
-use DragonCode\Support\Helpers\Ables\Stringable;
 
 class Upgrade extends Processor
 {
     use Anonymous;
 
     public function handle(): void
     {
-        if ($this->alreadyUpgraded()) {
-            $this->notification->info('Action upgrade already done');
-
-            return;
-        }
-
         $this->run();
     }
 
+    protected function getFiles(string $path, ?Closure $filter = null): array
+    {
+        return $this->file->names($path, $filter, true);
+    }
+
     protected function run(): void
     {
         $this->moveFiles();
-        $this->moveConfig();
-        $this->callMigration();
-        $this->clean();
     }
 
     protected function moveFiles(): void
     {
-        foreach ($this->getOldFiles() as $filename) {
-            $this->notification->task($filename, fn () => $this->move($filename));
+        foreach ($this->getProjectFiles() as $filename) {
+            $this->notification->task($filename, fn () => $this->replace($filename));
         }
     }
 
-    protected function move(string $filename): void
+    protected function replace(string $filename): void
     {
         $content = $this->open($filename);
 
-        $content = $this->replaceNamespace($content);
-        $content = $this->replaceClassName($content);
-        $content = $this->replaceDeclareStrictType($content);
-        $content = $this->replaceWithInvoke($content);
-        $content = $this->replaceProperties($content);
+        $content = $this->replaceCommandNames($content);
 
         $this->store($filename, $content);
     }
 
-    protected function clean(): void
-    {
-        $this->notification->task(
-            'Delete old directory',
-            fn () => Directory::ensureDelete($this->oldPath())
-        );
-    }
-
     protected function open(string $filename): string
     {
-        return file_get_contents($this->oldPath($filename . '.php'));
+        return file_get_contents($this->basePath($filename));
     }
 
     protected function store(string $filename, string $content): void
     {
-        File::store($this->newPath($filename . '.php'), $content);
+        File::store($this->basePath($filename), $content);
     }
 
-    protected function replaceNamespace(string $content): string
+    protected function replaceCommandNames(string $content): string
     {
         return Str::of($content)->replace(
-            ['DragonCode\\LaravelActions\\Support\\Actionable', 'Actionable'],
-            ['DragonCode\\LaravelActions\\Action', 'Action']
+            [
+                'make:migration:action',
+                'migrate:actions',
+                'migrate:actions:fresh',
+                'migrate:actions:install',
+                'migrate:actions:refresh',
+                'migrate:actions:reset',
+                'migrate:actions:rollback',
+                'migrate:actions:status',
+                'migrate:actions:upgrade',
+            ],
+            [
+                Names::MAKE,
+                Names::ACTIONS,
+                Names::FRESH,
+                Names::INSTALL,
+                Names::REFRESH,
+                Names::RESET,
+                Names::ROLLBACK,
+                Names::STATUS,
+                Names::UPGRADE,
+            ],
         )->toString();
     }
 
-    protected function replaceClassName(string $content): string
+    protected function getProjectFiles(): array
     {
-        return Str::of($content)
-            ->pregReplace('/((?:return\s+new\s+class\s*\(?\s*\)?|final\s+class|class)\s*.+extends\s+Action)/', 'return new class () extends Action')
-            ->trim()
-            ->trim(';')
-            ->append(';')
-            ->append(PHP_EOL)
-            ->toString();
-    }
-
-    protected function replaceDeclareStrictType(string $content): string
-    {
-        return Str::of($content)
-            ->replace('(declare\s*\(\s*strict_types\s*=\s*[1|0]\);)', '')
-            ->replace("<?php\n", "<?php\n\ndeclare(strict_types=1);\n")
-            ->toString();
-    }
-
-    protected function replaceWithInvoke(string $content): string
-    {
-        return Str::of($content)
-            ->when(! Str::matchContains($content, '/public\s+function\s+down/'), function (Stringable $string) {
-                return $string->pregReplace('/(public\s+function\s+up)/', 'public function __invoke');
-            })->toString();
-    }
-
-    protected function replaceProperties(string $content): string
-    {
-        return Str::of($content)
-            ->pregReplace('/protected\s+\$once/', 'protected bool $once')
-            ->pregReplace('/protected\s+\$transactions/', 'protected bool $transactions')
-            ->pregReplace('/protected\s+\$transaction_attempts/', 'protected int $transactionAttempts')
-            ->pregReplace('/protected\s+\$environment/', 'protected string|array|null $environment')
-            ->pregReplace('/protected\s+\$except_environment/', 'protected string|array|null $exceptEnvironment')
-            ->pregReplace('/protected\s+\$before/', 'protected bool $before')
-            ->toString();
-    }
-
-    protected function moveConfig(): void
-    {
-        $this->notification->task('Moving config file', function () {
-            $this->runCommand('vendor:publish', [
-                '--provider' => ServiceProvider::class,
-                '--force'    => true,
-            ]);
-
-            $path = config_path('actions.php');
-
-            $table = config('database.actions', 'migration_actions');
-
-            $content = Str::replace(file_get_contents($path), "'table' => 'migration_actions'", "'table' => '$table'");
-
-            file_put_contents($path, $content);
-        });
-    }
-
-    protected function callMigration(): void
-    {
-        $this->notification->task('Call migration', function () {
-            $path = $this->allowAnonymousMigrations()
-                ? __DIR__ . '/../../database/migrations/anonymous/2022_08_18_180137_change_migration_actions_table.php'
-                : __DIR__ . '/../../database/migrations/named/2022_08_18_180137_change_migration_actions_table.php';
-
-            $this->runCommand('migrate', [
-                '--path'     => $path,
-                '--realpath' => true,
-                '--force'    => true,
-            ]);
-        });
-    }
-
-    protected function getOldFiles(): array
-    {
-        return $this->getFiles($this->oldPath());
-    }
-
-    protected function oldPath(?string $filename = null): string
-    {
-        return database_path('actions/' . $filename);
-    }
-
-    protected function newPath(?string $filename = null): string
-    {
-        return $this->options->path . '/' . $filename;
+        return $this->getFiles(
+            base_path(),
+            fn (string $path) => Str::endsWith($path, '.php')
+                && ! Str::startsWith(realpath($path), [
+                    realpath(base_path('vendor')),
+                    realpath(base_path('node_modules')),
+                ])
+        );
     }
 
-    protected function alreadyUpgraded(): bool
+    protected function basePath(?string $filename = null): string
     {
-        return Directory::exists($this->newPath());
+        return base_path($filename);
     }
 }