Update code-style

Author: actions-user

src/Concerns/Artisan.php

@@ -11,8 +11,8 @@ trait Artisan
     /**
      * Run an Artisan console command by name.
      *
-     * @param  string  $command
-     * @param  array  $parameters
+     * @param string $command
+     * @param array $parameters
      *
      * @return void
      */

src/Concerns/Infoable.php

@@ -10,9 +10,9 @@ trait Infoable
     /**
      * Write a string as standard output.
      *
-     * @param  string  $string
-     * @param  string|null  $style
-     * @param  int|string|null  $verbosity
+     * @param string $string
+     * @param string|null $style
+     * @param int|string|null $verbosity
      */
     public function line($string, $style = null, $verbosity = null)
     {

src/Concerns/Optionable.php

@@ -12,7 +12,7 @@ protected function optionDatabase(): ?string
         return $this->input->getOption('database');
     }
 
-    protected function optionStep(int $default = null): ?int
+    protected function optionStep(?int $default = null): ?int
     {
         return $this->input->getOption('step') ?: $default;
     }

src/Console/Make.php

@@ -6,6 +6,7 @@
 use DragonCode\LaravelActions\Concerns\Database;
 use DragonCode\LaravelActions\Concerns\Infoable;
 use DragonCode\LaravelActions\Constants\Names;
+use Exception;
 use Illuminate\Database\Console\Migrations\BaseCommand;
 use Illuminate\Database\Migrations\MigrationCreator;
 use Illuminate\Support\Composer;
@@ -49,8 +50,8 @@ class Make extends BaseCommand
     /**
      * Create a new action install command instance.
      *
-     * @param  \Illuminate\Database\Migrations\MigrationCreator  $creator
-     * @param  \Illuminate\Support\Composer  $composer
+     * @param \Illuminate\Database\Migrations\MigrationCreator $creator
+     * @param \Illuminate\Support\Composer $composer
      */
     public function __construct(MigrationCreator $creator, Composer $composer)
     {
@@ -63,7 +64,7 @@ public function __construct(MigrationCreator $creator, Composer $composer)
     /**
      * Execute the console command.
      *
-     * @throws \Exception
+     * @throws Exception
      */
     public function handle()
     {
@@ -77,9 +78,9 @@ public function handle()
     /**
      * Write the action file to disk.
      *
-     * @param  string  $name
+     * @param string $name
      *
-     * @throws \Exception
+     * @throws Exception
      */
     protected function writeMigration(string $name)
     {

src/Console/Refresh.php

@@ -63,8 +63,8 @@ public function handle()
     /**
      * Run the rollback command.
      *
-     * @param  string|null  $database
-     * @param  int|null  $step
+     * @param string|null $database
+     * @param int|null $step
      */
     protected function runRollback(?string $database, ?int $step)
     {
@@ -78,7 +78,7 @@ protected function runRollback(?string $database, ?int $step)
     /**
      * Run the reset command.
      *
-     * @param  string|null  $database
+     * @param string|null $database
      */
     protected function runReset(?string $database)
     {

src/Console/Reset.php

@@ -42,7 +42,7 @@ class Reset extends BaseCommand
     /**
      * Create a new migration rollback command instance.
      *
-     * @param  \DragonCode\LaravelActions\Support\Migrator  $migrator
+     * @param \DragonCode\LaravelActions\Support\Migrator $migrator
      */
     public function __construct(Migrator $migrator)
     {

src/Support/Actionable.php

@@ -42,14 +42,14 @@ abstract class Actionable extends Migration implements Contract
      *
      * @var array|string|null
      */
-    protected $environment = null;
+    protected $environment;
 
     /**
      * Determines in which environment it should not run.
      *
      * @var array|string|null
      */
-    protected $except_environment = null;
+    protected $except_environment;
 
     /**
      * Reverse the actions.
@@ -122,7 +122,7 @@ public function allow(): bool
     }
 
     /**
-     * Method to be called when the job completes successfully
+     * Method to be called when the job completes successfully.
      *
      * @return void
      */

src/Support/Migrator.php

@@ -3,8 +3,8 @@
 namespace DragonCode\LaravelActions\Support;
 
 use DragonCode\Contracts\LaravelActions\Actionable as ActionableContract;
-use DragonCode\LaravelActions\Concerns\Infoable;
 use DragonCode\LaravelActions\Concerns\Anonymous;
+use DragonCode\LaravelActions\Concerns\Infoable;
 use Illuminate\Database\Migrations\Migrator as BaseMigrator;
 use Illuminate\Support\Facades\DB;
 use Throwable;
@@ -28,11 +28,11 @@ public function usingConnection($name, callable $callback)
     /**
      * Run "up" a migration instance.
      *
-     * @param  string  $file
-     * @param  int  $batch
-     * @param  bool  $pretend
+     * @param string $file
+     * @param int $batch
+     * @param bool $pretend
      *
-     * @throws \Throwable
+     * @throws Throwable
      */
     protected function runUp($file, $batch, $pretend)
     {
@@ -82,11 +82,11 @@ protected function runUp($file, $batch, $pretend)
     /**
      * Run "down" a migration instance.
      *
-     * @param  string  $file
-     * @param  object  $migration
-     * @param  bool  $pretend
+     * @param string $file
+     * @param object $migration
+     * @param bool $pretend
      *
-     * @throws \Throwable
+     * @throws Throwable
      */
     protected function runDown($file, $migration, $pretend)
     {
@@ -112,10 +112,10 @@ protected function runDown($file, $migration, $pretend)
     /**
      * Starts the execution of code, starting database transactions, if necessary.
      *
-     * @param  object  $migration
-     * @param  string  $method
+     * @param object $migration
+     * @param string $method
      *
-     * @throws \Throwable
+     * @throws Throwable
      */
     protected function runMigration($migration, $method)
     {
@@ -135,7 +135,7 @@ protected function runMigration($migration, $method)
     /**
      * Whether it is necessary to record information about the execution in the database.
      *
-     * @param  \DragonCode\Contracts\LaravelActions\Actionable|object  $migration
+     * @param \DragonCode\Contracts\LaravelActions\Actionable|object $migration
      *
      * @return bool
      */
@@ -147,7 +147,7 @@ protected function allowLogging(ActionableContract $migration): bool
     /**
      * Whether the action needs to be executed in the current environment.
      *
-     * @param  \DragonCode\Contracts\LaravelActions\Actionable|object  $migration
+     * @param \DragonCode\Contracts\LaravelActions\Actionable|object $migration
      *
      * @return bool
      */
@@ -167,17 +167,13 @@ protected function allowEnvironment(ActionableContract $migration): bool
             return false;
         }
 
-        if (! empty($except) && in_array($environment, $except)) {
-            return false;
-        }
-
-        return true;
+        return ! (! empty($except) && in_array($environment, $except));
     }
 
     /**
      * Whether it is necessary to call database transactions at runtime.
      *
-     * @param  \DragonCode\LaravelActions\Support\Actionable|object  $migration
+     * @param \DragonCode\LaravelActions\Support\Actionable|object $migration
      *
      * @return bool
      */
@@ -189,7 +185,7 @@ protected function enabledTransactions(ActionableContract $migration): bool
     /**
      * The number of attempts to execute a request within a transaction before throwing an error.
      *
-     * @param  \DragonCode\LaravelActions\Support\Actionable|object  $migration
+     * @param \DragonCode\LaravelActions\Support\Actionable|object $migration
      *
      * @return int
      */
@@ -201,10 +197,11 @@ protected function transactionAttempts(ActionableContract $migration): int
     }
 
     /**
-     * @param  \DragonCode\Contracts\LaravelActions\Actionable|object  $migration
-     * @param  callable  $handle
+     * @param \DragonCode\Contracts\LaravelActions\Actionable|object $migration
+     * @param callable $handle
+     *
+     * @throws Throwable
      *
-     * @throws \Throwable
      * @return void
      */
     protected function runMigrationHandle(ActionableContract $migration, callable $handle)
@@ -221,7 +218,7 @@ protected function runMigrationHandle(ActionableContract $migration, callable $h
     }
 
     /**
-     * @param  \DragonCode\Contracts\LaravelActions\Actionable|object  $migration
+     * @param \DragonCode\Contracts\LaravelActions\Actionable|object $migration
      *
      * @return void
      */
@@ -231,7 +228,7 @@ protected function runSuccess(ActionableContract $migration): void
     }
 
     /**
-     * @param  \DragonCode\Contracts\LaravelActions\Actionable|object  $migration
+     * @param \DragonCode\Contracts\LaravelActions\Actionable|object $migration
      *
      * @return void
      */

tests/Concerns/Files.php

@@ -58,7 +58,7 @@ protected function copyFailedTransaction(): void
         File::copy($source, $this->targetDirectory('2021_02_15_124852_test_failed_transactions.php'));
     }
 
-    protected function targetDirectory(string $path = null): string
+    protected function targetDirectory(?string $path = null): string
     {
         $dir = database_path('actions');
 

tests/fixtures/app/anonymous/actions/2020_12_07_153105_foo_bar.php

@@ -5,7 +5,7 @@
 use Illuminate\Support\Facades\DB;
 use Ramsey\Uuid\Uuid;
 
-return new class extends Actionable {
+return new class () extends Actionable {
     public function up(): void
     {
         $this->table()->insert([