Suppressions and summary corrections.

Author: Timovzl

DomainModeling.Tests/EntityFramework/EntityFrameworkConfigurationGeneratorTests.cs

@@ -108,7 +108,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 internal sealed class DomainEventForEF : IDomainObject
 {
 	/// <summary>
-	/// This lets us test if a constructor as used or not.
+	/// This lets us test if a constructor is used or not.
 	/// </summary>
 	public bool HasFieldInitializerRun { get; } = true;
 
@@ -131,7 +131,7 @@ public DomainEventForEF(DomainEventForEFId id, object ignored)
 internal sealed class EntityForEF : Entity<EntityForEFId, int>
 {
 	/// <summary>
-	/// This lets us test if a constructor as used or not.
+	/// This lets us test if a constructor is used or not.
 	/// </summary>
 	public bool HasFieldInitializerRun { get; } = true;
 
@@ -146,12 +146,14 @@ public EntityForEF(ValueObjectForEF values)
 		this.Values = values;
 	}
 
+#pragma warning disable IDE0079 // Remove unnecessary suppression -- Suppression below is falsely flagged as unnecessary
 #pragma warning disable CS8618 // Reconstitution constructor
 	private EntityForEF()
 		: base(default)
 	{
 	}
 #pragma warning restore CS8618
+#pragma warning restore IDE0079
 }
 
 [WrapperValueObject<string>]
@@ -160,7 +162,7 @@ internal sealed partial class Wrapper1ForEF
 	protected override StringComparison StringComparison => StringComparison.Ordinal;
 
 	/// <summary>
-	/// This lets us test if a constructor as used or not.
+	/// This lets us test if a constructor is used or not.
 	/// </summary>
 	public bool HasFieldInitializerRun { get; } = true;
 
@@ -177,7 +179,7 @@ public Wrapper1ForEF(string value)
 internal sealed partial class Wrapper2ForEF
 {
 	/// <summary>
-	/// This lets us test if a constructor as used or not.
+	/// This lets us test if a constructor is used or not.
 	/// </summary>
 	public bool HasFieldInitializerRun { get; } = true;
 
@@ -194,7 +196,7 @@ public Wrapper2ForEF(decimal value)
 internal sealed partial class ValueObjectForEF
 {
 	/// <summary>
-	/// This lets us test if a constructor as used or not.
+	/// This lets us test if a constructor is used or not.
 	/// </summary>
 	public bool HasFieldInitializerRun = true;
 

DomainModeling/Comparisons/DictionaryComparer.cs

@@ -76,10 +76,12 @@ public static int GetDictionaryHashCode<TKey, TValue>(Dictionary<TKey, TValue>?
 	public static bool DictionaryEquals<TKey, TValue>(IReadOnlyDictionary<TKey, TValue>? left, IReadOnlyDictionary<TKey, TValue>? right)
 	{
 		// Devirtualized path for practically all dictionaries
+#pragma warning disable IDE0079 // Remove unnecessary suppression -- Suppression below is falsely flagged as unnecessary
 #pragma warning disable CS8714 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'notnull' constraint. -- Was type-checked
 		if (left is Dictionary<TKey, TValue> leftDict && right is Dictionary<TKey, TValue> rightDict)
 			return DictionaryEquals(leftDict, rightDict);
 #pragma warning restore CS8714 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'notnull' constraint.
+#pragma warning restore IDE0079
 
 		return GetResult(left, right);
 
@@ -115,10 +117,12 @@ static bool GetResult(IReadOnlyDictionary<TKey, TValue>? left, IReadOnlyDictiona
 	public static bool DictionaryEquals<TKey, TValue>(IDictionary<TKey, TValue>? left, IDictionary<TKey, TValue>? right)
 	{
 		// Devirtualized path for practically all dictionaries
+#pragma warning disable IDE0079 // Remove unnecessary suppression -- Suppression below is falsely flagged as unnecessary
 #pragma warning disable CS8714 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'notnull' constraint. -- Was type-checked
 		if (left is Dictionary<TKey, TValue> leftDict && right is Dictionary<TKey, TValue> rightDict)
 			return DictionaryEquals(leftDict, rightDict);
 #pragma warning restore CS8714 // The type cannot be used as type parameter in the generic type or method. Nullability of type argument doesn't match 'notnull' constraint.
+#pragma warning restore IDE0079
 
 		return GetResult(left, right);
 

DomainModeling/ISerializableDomainObject.cs

@@ -3,7 +3,7 @@
 namespace Architect.DomainModeling;
 
 /// <summary>
-/// An <see cref="IDomainObject"/> of type <typeparamref name="TModel"/> that can be serialized and deserialized to underlying type <typeparamref name="TUnderlying"/>.
+/// A domain object of type <typeparamref name="TModel"/> that can be serialized to and deserialized from underlying type <typeparamref name="TUnderlying"/>.
 /// </summary>
 public interface ISerializableDomainObject<
 	[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)] TModel,