chore: suppress new clippy lints (#905)

Author: vil02

Cargo.toml

@@ -44,7 +44,6 @@ manual_assert = { level = "allow", priority = 1 }
 manual_let_else = { level = "allow", priority = 1 }
 manual_string_new = { level = "allow", priority = 1 }
 many_single_char_names = { level = "allow", priority = 1 }
-match_on_vec_items = { level = "allow", priority = 1 }
 match_wildcard_for_single_variants = { level = "allow", priority = 1 }
 missing_errors_doc = { level = "allow", priority = 1 }
 missing_fields_in_debug = { level = "allow", priority = 1 }
@@ -69,6 +68,7 @@ used_underscore_binding = { level = "allow", priority = 1 }
 ref_option = { level = "allow", priority = 1 }
 unnecessary_semicolon = { level = "allow", priority = 1 }
 ignore_without_reason = { level = "allow", priority = 1 }
+needless_for_each = { level = "allow", priority = 1 }
 # restriction-lints:
 absolute_paths = { level = "allow", priority = 1 }
 arithmetic_side_effects = { level = "allow", priority = 1 }
@@ -169,3 +169,5 @@ doc_overindented_list_items = { level = "allow", priority = 1 }
 # complexity-lints
 precedence = { level = "allow", priority = 1 }
 manual_div_ceil = { level = "allow", priority = 1 }
+# perf-lints
+cloned_ref_to_slice_refs = { level = "allow", priority = 1 }

src/data_structures/avl_tree.rs

@@ -85,7 +85,7 @@ impl<T: Ord> AVLTree<T> {
     }
 
     /// Returns an iterator that visits the nodes in the tree in order.
-    fn node_iter(&self) -> NodeIter<T> {
+    fn node_iter(&self) -> NodeIter<'_, T> {
         let cap = self.root.as_ref().map_or(0, |n| n.height);
         let mut node_iter = NodeIter {
             stack: Vec::with_capacity(cap),
@@ -100,7 +100,7 @@ impl<T: Ord> AVLTree<T> {
     }
 
     /// Returns an iterator that visits the values in the tree in ascending order.
-    pub fn iter(&self) -> Iter<T> {
+    pub fn iter(&self) -> Iter<'_, T> {
         Iter {
             node_iter: self.node_iter(),
         }

src/data_structures/binary_search_tree.rs

@@ -188,7 +188,7 @@ impl<T> BinarySearchTreeIter<'_, T>
 where
     T: Ord,
 {
-    pub fn new(tree: &BinarySearchTree<T>) -> BinarySearchTreeIter<T> {
+    pub fn new(tree: &BinarySearchTree<T>) -> BinarySearchTreeIter<'_, T> {
         let mut iter = BinarySearchTreeIter { stack: vec![tree] };
         iter.stack_push_left();
         iter

src/data_structures/probabilistic/bloom_filter.rs

@@ -21,6 +21,7 @@ pub trait BloomFilter<Item: Hash> {
 /// When looking for an item, we hash its value and retrieve the boolean at index `hash(item) % CAPACITY`
 /// If it's `false` it's absolutely sure the item isn't present
 /// If it's `true` the item may be present, or maybe another one produces the same hash
+#[allow(dead_code)]
 #[derive(Debug)]
 struct BasicBloomFilter<const CAPACITY: usize> {
     vec: [bool; CAPACITY],

src/data_structures/treap.rs

@@ -85,7 +85,7 @@ impl<T: Ord> Treap<T> {
     }
 
     /// Returns an iterator that visits the nodes in the tree in order.
-    fn node_iter(&self) -> NodeIter<T> {
+    fn node_iter(&self) -> NodeIter<'_, T> {
         let mut node_iter = NodeIter { stack: Vec::new() };
         // Initialize stack with path to leftmost child
         let mut child = &self.root;
@@ -97,7 +97,7 @@ impl<T: Ord> Treap<T> {
     }
 
     /// Returns an iterator that visits the values in the tree in ascending order.
-    pub fn iter(&self) -> Iter<T> {
+    pub fn iter(&self) -> Iter<'_, T> {
         Iter {
             node_iter: self.node_iter(),
         }

src/data_structures/veb_tree.rs

@@ -58,7 +58,7 @@ impl VebTree {
         self.max
     }
 
-    pub fn iter(&self) -> VebTreeIter {
+    pub fn iter(&self) -> VebTreeIter<'_> {
         VebTreeIter::new(self)
     }
 

src/general/genetic.rs

@@ -36,6 +36,7 @@ pub trait SelectionStrategy<Rng: rand::Rng> {
 
 /// A roulette wheel selection strategy
 /// https://en.wikipedia.org/wiki/Fitness_proportionate_selection
+#[allow(dead_code)]
 pub struct RouletteWheel<Rng: rand::Rng> {
     rng: Rng,
 }
@@ -84,6 +85,7 @@ impl<Rng: rand::Rng> SelectionStrategy<Rng> for RouletteWheel<Rng> {
     }
 }
 
+#[allow(dead_code)]
 pub struct Tournament<const K: usize, Rng: rand::Rng> {
     rng: Rng,
 }

src/math/random.rs

@@ -102,7 +102,7 @@ impl PCG32 {
     pub fn get_state(&self) -> u64 {
         self.state
     }
-    pub fn iter_mut(&mut self) -> IterMut {
+    pub fn iter_mut(&mut self) -> IterMut<'_> {
         IterMut { pcg: self }
     }
 }