Skip to content

Improve is_image detection #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve is_image detection #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ end
function expand_output_path(cropbox)
local filename = mp.get_property_native("filename")
local playback_time = mp.get_property_native("playback-time")
local duration = mp.get_property_native("duration")
local estimated_frame_count = mp.get_property_native("estimated-frame-count")

local filename_without_ext, extension = filename:match("^(.+)%.(.-)$")

Expand All @@ -87,7 +87,7 @@ function expand_output_path(cropbox)
pos = mp.get_property_native("playback-time"),

full = false,
is_image = (duration <= 1 and playback_time == 0),
is_image = (estimated_frame_count <= 1 and playback_time == 0),

crop_w = cropbox.w,
crop_h = cropbox.h,
Expand Down Expand Up @@ -181,11 +181,11 @@ function screenshot_crop_or_mask(crop_or_mask, is_mask)
end

local playback_time = mp.get_property_native("playback-time")
local duration = mp.get_property_native("duration")
local estimated_frame_count = mp.get_property_native("estimated-frame-count")

local input_path = nil

if option_values.skip_screenshot_for_images and duration <= 1 and playback_time == 0 then
if option_values.skip_screenshot_for_images and estimated_frame_count <= 1 and playback_time == 0 then
-- Seems to be an image (or at least static file)
input_path = mp.get_property_native("path")
temporary_screenshot_path = nil
Expand Down