Merge pull request #34 from Telefonica/fix_ensure_absent_instance

Fix ensure absent instance

Author: mrodm

manifests/instance.pp

@@ -129,29 +129,34 @@
     require => Archive["${instance_name}-${archive_name}"],
   }
 
-  exec { "${instance_name}-check-runner-configured":
-    user    => $user,
-    cwd     => "${github_actions_runner::root_dir}/${instance_name}",
-    command => 'true',
-    unless  => "test -f ${github_actions_runner::root_dir}/${instance_name}/runsvc.sh",
-    path    => ['/bin', '/usr/bin'],
-    notify  => Exec["${instance_name}-run_configure_install_runner.sh"],
+  if $ensure == 'present' {
+      exec { "${instance_name}-check-runner-configured":
+        user    => $user,
+        cwd     => '/srv',
+        command => 'true',
+        unless  => "test -f ${github_actions_runner::root_dir}/${instance_name}/runsvc.sh",
+        path    => ['/bin', '/usr/bin'],
+        notify  => Exec["${instance_name}-run_configure_install_runner.sh"],
+      }
   }
 
   exec { "${instance_name}-ownership":
     user        => $user,
     cwd         => $github_actions_runner::root_dir,
     command     => "/bin/chown -R ${user}:${group} ${github_actions_runner::root_dir}/${instance_name}",
     refreshonly => true,
-    path        => "/tmp/${instance_name}-${archive_name}",
-    subscribe   => Archive["${instance_name}-${archive_name}"]
+    path        => ['/bin', '/usr/bin'],
+    subscribe   => Archive["${instance_name}-${archive_name}"],
+    onlyif      => "test -d ${github_actions_runner::root_dir}/${instance_name}"
   }
 
   exec { "${instance_name}-run_configure_install_runner.sh":
     user        => $user,
     cwd         => "${github_actions_runner::root_dir}/${instance_name}",
     command     => "${github_actions_runner::root_dir}/${instance_name}/configure_install_runner.sh",
-    refreshonly => true
+    refreshonly => true,
+    path        => ['/bin', '/usr/bin'],
+    onlyif      => "test -d ${github_actions_runner::root_dir}/${instance_name}"
   }
 
   $active_service = $ensure ? {

spec/classes/github_actions_runner_spec.rb

@@ -379,6 +379,10 @@
           is_expected.to contain_file('/some_dir/actions-runner-2.272.0/first_runner/configure_install_runner.sh').with(
             'ensure' => 'absent',
           )
+
+          is_expected.not_to contain_exec('first_runner-check-runner-configured')
+          is_expected.to contain_exec('first_runner-ownership')
+          is_expected.to contain_exec('first_runner-run_configure_install_runner.sh')
         end
       end