code tuning

Author: Taymindis

src/ngx_http_c_func_module.c

@@ -122,6 +122,7 @@ static ngx_int_t ngx_http_c_func_proceed_init_calls(ngx_cycle_t* cycle,  ngx_htt
 static u_char* ngx_http_c_func_strdup(ngx_pool_t *pool, const char *src, size_t len);
 
 static ngx_int_t ngx_http_c_func_get_resp_var(ngx_http_request_t *r, ngx_http_variable_value_t *v, uintptr_t data);
+static void ngx_http_c_func_set_resp_var_with_r(ngx_http_request_t *r, ngx_http_c_func_ctx_t *ctx, const char* resp_content);
 
 /*** Download Feature Support ***/
 typedef struct {
@@ -144,7 +145,7 @@ static ngx_http_c_fun_http_header_body* ngx_http_c_fun_https_request( ngx_cycle_
 #endif
 /*** End Download Feature Support ***/
 
-/*Extern interface*/
+/**Extern interface**/
 void ngx_http_c_func_log_debug(ngx_http_c_func_ctx_t *ctx, const char* msg);
 void ngx_http_c_func_log_info(ngx_http_c_func_ctx_t *ctx, const char* msg);
 void ngx_http_c_func_log_warn(ngx_http_c_func_ctx_t *ctx, const char* msg);
@@ -165,20 +166,10 @@ void* ngx_http_c_func_cache_get(void *shared_mem, const char* key);
 void* ngx_http_c_func_cache_put(void *shared_mem, const char* key, void* value);
 void* ngx_http_c_func_cache_new(void *shared_mem, const char* key, size_t size);
 void* ngx_http_c_func_cache_remove(void *shared_mem, const char* key);
+void ngx_http_c_func_set_resp_var(ngx_http_c_func_ctx_t *ctx, const char* resp_content);
+void ngx_http_c_func_write_resp(ngx_http_c_func_ctx_t *ctx, uintptr_t status_code, const char* status_line, const char* content_type, const char* resp_content);
+/**End Extern interface**/
 
-void
-ngx_http_c_func_set_resp_var(
-    ngx_http_c_func_ctx_t *ctx,
-    const char* resp_content
-);
-
-void ngx_http_c_func_write_resp(
-    ngx_http_c_func_ctx_t *ctx,
-    uintptr_t status_code,
-    const char* status_line,
-    const char* content_type,
-    const char* resp_content
-);
 
 // static ngx_conf_post_t ngx_http_c_func_srv_post_conf = {
 //     ngx_http_c_func_srv_post_conf_handler
@@ -1368,6 +1359,27 @@ ngx_http_c_func_set_resp_var(
     }
 }
 
+static void
+ngx_http_c_func_set_resp_var_with_r(
+    ngx_http_request_t *r,
+    ngx_http_c_func_ctx_t *ctx,
+    const char* resp_content
+) {
+    ngx_http_c_func_internal_ctx_t *internal_ctx;
+    internal_ctx = ngx_http_get_module_ctx(r, ngx_http_c_func_module);
+
+    if (internal_ctx != NULL) {
+        internal_ctx->resp_len = ngx_strlen(resp_content);
+        internal_ctx->resp = (u_char*)resp_content;
+
+        /** Decline means continue to next handler for this phase **/
+        ctx->__rc__ = NGX_DECLINED;
+    } else {
+        ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, "Error while storing resp to variable.");
+        ctx->__rc__ = NGX_HTTP_INTERNAL_SERVER_ERROR;
+    }
+}
+
 void
 ngx_http_c_func_write_resp(
     ngx_http_c_func_ctx_t *ctx,
@@ -1384,9 +1396,10 @@ ngx_http_c_func_write_resp(
     if ( ((ngx_http_c_func_loc_conf_t*) ngx_http_get_module_loc_conf(r, ngx_http_c_func_module) )->_is_call_to_var ) {
         ngx_log_error(NGX_LOG_WARN,
                       r->connection->log,
-                      0,
-                      ", \n Recommended to call ngx_http_c_func_set_resp_var. \n ngx_http_c_func_write_resp only applicable when no variable stored");
-        return ngx_http_c_func_set_resp_var(ctx, resp_content);
+                      0, "Recommended to call ngx_http_c_func_set_resp_var. \
+                      ngx_http_c_func_write_resp only applicable when no variable specified");
+        ngx_http_c_func_set_resp_var_with_r(r, ctx, resp_content);
+        return;
     }
 
     /* Set the Content-Type header. */