In JavaScriptEngineSwitcher.ChakraCore no longer performed cleaning of reused buffers when returning to the pool

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsPropertyId.cs

@@ -71,7 +71,7 @@ public string Name
 				}
 				finally
 				{
-					byteArrayPool.Return(buffer, true);
+					byteArrayPool.Return(buffer);
 				}
 
 				return name;

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsValue.cs

@@ -746,7 +746,7 @@ public int ToInt32()
 				}
 				finally
 				{
-					charArrayPool.Return(buffer, true);
+					charArrayPool.Return(buffer);
 				}
 			}
 			else
@@ -771,7 +771,7 @@ public int ToInt32()
 				}
 				finally
 				{
-					byteArrayPool.Return(buffer, true);
+					byteArrayPool.Return(buffer);
 				}
 			}
 

src/JavaScriptEngineSwitcher.ChakraCore/Polyfills/System/Buffers/ArrayPool.cs

@@ -87,11 +87,7 @@ private static ArrayPool<T> EnsureSharedCreated()
 		/// if it's determined that the pool already has enough buffers stored.
 		/// </remarks>
 		/// <param name="array">The buffer previously obtained from <see cref="Rent"/> to return to the pool</param>
-		/// <param name="clearArray">If <c>true</c> and if the pool will store the buffer to enable subsequent
-		/// reuse, <see cref="Return"/> will clear <paramref name="array"/> of its contents so that a subsequent
-		/// consumer via <see cref="Rent"/> will not see the previous consumer's content. If <c>false</c> or
-		/// if the pool will release the buffer, the array's contents are left unchanged.</param>
-		public abstract void Return(T[] array, bool clearArray = false);
+		public abstract void Return(T[] array);
 	}
 }
 #endif

src/JavaScriptEngineSwitcher.ChakraCore/Polyfills/System/Buffers/DefaultArrayPool.cs

@@ -125,7 +125,7 @@ public override T[] Rent(int minimumLength)
 			return buffer;
 		}
 
-		public override void Return(T[] array, bool clearArray = false)
+		public override void Return(T[] array)
 		{
 			if (array == null)
 			{
@@ -144,12 +144,6 @@ public override void Return(T[] array, bool clearArray = false)
 			// If we can tell that the buffer was allocated, drop it. Otherwise, check if we have space in the pool
 			if (bucket < _buckets.Length)
 			{
-				// Clear the array if the user requests
-				if (clearArray)
-				{
-					Array.Clear(array, 0, array.Length);
-				}
-
 				// Return the buffer to its bucket. In the future, we might consider having Return return false
 				// instead of dropping a bucket, in which case we could try to return to a lower-sized bucket,
 				// just as how in Rent we allow renting from a higher-sized bucket.