In JavaScriptEngineSwitcher.ChakraCore fixed a implementation of the JsSerializedLoadScriptCallback delegate

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

@@ -22,8 +22,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
  * JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
 		<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
 		<PackageTags>JavaScriptEngineSwitcher;JavaScript;ECMAScript;ChakraCore</PackageTags>
-		<PackageReleaseNotes>1. ChakraCore was updated to version 1.8.4;
-2. Added a ability to pre-compile scripts.</PackageReleaseNotes>
+		<PackageReleaseNotes>Fixed a implementation of the `JsSerializedLoadScriptCallback` delegate.</PackageReleaseNotes>
 	</PropertyGroup>
 
 	<Import Project="../../build/common.props" />

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsContext.cs

@@ -257,7 +257,8 @@ public static JsValue ParseSerializedScript(string script, byte[] buffer, JsSour
 				JsSerializedLoadScriptCallback scriptLoadCallback = (JsSourceContext context,
 					out JsValue value, out JsParseScriptAttributes parseAttributes) =>
 				{
-					value = JsValue.FromString(script);
+					byte[] bytes = Encoding.GetEncoding(0).GetBytes(script);
+					value = JsValue.CreateExternalArrayBuffer(bytes);
 					parseAttributes = JsParseScriptAttributes.None;
 
 					return true;
@@ -390,7 +391,8 @@ public static JsValue RunSerializedScript(string script, byte[] buffer, JsSource
 				JsSerializedLoadScriptCallback scriptLoadCallback = (JsSourceContext context,
 					out JsValue value, out JsParseScriptAttributes parseAttributes) =>
 				{
-					value = JsValue.FromString(script);
+					byte[] bytes = Encoding.GetEncoding(0).GetBytes(script);
+					value = JsValue.CreateExternalArrayBuffer(bytes);
 					parseAttributes = JsParseScriptAttributes.None;
 
 					return true;

src/JavaScriptEngineSwitcher.ChakraCore/JsRt/JsSerializedLoadScriptCallback.cs

@@ -3,8 +3,9 @@
 	/// <summary>
 	/// Called by the runtime to load the source code of the serialized script
 	/// </summary>
-	/// <param name="sourceContext">The context passed to Js[Parse|Run]Serialized</param>
-	/// <param name="value">The result of the compiled script</param>
+	/// <param name="sourceContext">A cookie identifying the script that can be used
+	/// by debuggable script contexts</param>
+	/// <param name="value">The script returned</param>
 	/// <param name="parseAttributes">Attribute mask for parsing the script</param>
 	/// <returns>true if the operation succeeded, false otherwise</returns>
 	internal delegate bool JsSerializedLoadScriptCallback(JsSourceContext sourceContext,

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

@@ -30,8 +30,7 @@
    =============
    RELEASE NOTES
    =============
-   1. ChakraCore was updated to version 1.8.4;
-   2. Added a ability to pre-compile scripts.
+   Fixed a implementation of the `JsSerializedLoadScriptCallback` delegate.
 
    =============
    DOCUMENTATION

test/JavaScriptEngineSwitcher.Tests/JavaScriptEngineSwitcher.Tests.csproj

@@ -60,7 +60,7 @@
 	</ItemGroup>
 
 	<ItemGroup>
-		<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.0" />
+		<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
 	</ItemGroup>
 
 </Project>