Skip to content

Commit dffa363

Browse files
authored
fix: remove qt disconnect warning (#613)
* fix: cannot disconnect from None Warning * fix: cannot disconnect from None Warning mypy compliant
1 parent ef68603 commit dffa363

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

tagstudio/src/qt/widgets/fields.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,25 +113,23 @@ def set_copy_callback(self, callback: Optional[MethodType]):
113113

114114
self.copy_callback = callback
115115
self.copy_button.clicked.connect(callback)
116-
if callback is not None:
117-
self.copy_button.is_connected = True
116+
self.copy_button.is_connected = callable(callback)
118117

119118
def set_edit_callback(self, callback: Callable):
120119
if self.edit_button.is_connected:
121120
self.edit_button.clicked.disconnect()
122121

123122
self.edit_callback = callback
124123
self.edit_button.clicked.connect(callback)
125-
if callback is not None:
126-
self.edit_button.is_connected = True
124+
self.edit_button.is_connected = callable(callback)
127125

128126
def set_remove_callback(self, callback: Callable):
129127
if self.remove_button.is_connected:
130128
self.remove_button.clicked.disconnect()
131129

132130
self.remove_callback = callback
133131
self.remove_button.clicked.connect(callback)
134-
self.remove_button.is_connected = True
132+
self.remove_button.is_connected = callable(callback)
135133

136134
def set_inner_widget(self, widget: "FieldWidget"):
137135
if self.field_layout.itemAt(0):

tagstudio/src/qt/widgets/preview_panel.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -875,10 +875,6 @@ def write_container(self, index: int, field: BaseField, is_mixed: bool = False):
875875
else:
876876
container = self.containers[index]
877877

878-
container.set_copy_callback(None)
879-
container.set_edit_callback(None)
880-
container.set_remove_callback(None)
881-
882878
if isinstance(field, TagBoxField):
883879
container.set_title(field.type.name)
884880
container.set_inline(False)

0 commit comments

Comments
 (0)