remove field.position unique constraint

Author: yedpodtrzitko

tagstudio/src/core/library/alchemy/fields.py

@@ -4,7 +4,7 @@
 from enum import Enum
 from typing import Any, TYPE_CHECKING
 
-from sqlalchemy import ForeignKey, ForeignKeyConstraint
+from sqlalchemy import ForeignKey
 from sqlalchemy.orm import Mapped, mapped_column, relationship, declared_attr
 
 from .db import Base
@@ -39,7 +39,7 @@ def entry(cls) -> Mapped[Entry]:
 
     @declared_attr
     def position(cls) -> Mapped[int]:
-        return mapped_column()
+        return mapped_column(default=0)
 
     def __hash__(self):
         return hash(self.__key())
@@ -66,13 +66,6 @@ def __eq__(self, value) -> bool:
 
 class TextField(BaseField):
     __tablename__ = "text_fields"
-    # constrain for combination of: entry_id, type_key and position
-    __table_args__ = (
-        ForeignKeyConstraint(
-            ["entry_id", "type_key", "position"],
-            ["text_fields.entry_id", "text_fields.type_key", "text_fields.position"],
-        ),
-    )
 
     value: Mapped[str | None]
 

tagstudio/src/core/library/alchemy/library.py

@@ -2,7 +2,6 @@
 import shutil
 from os import makedirs
 from pathlib import Path
-from random import randint
 from typing import Iterator, Any, Type
 from uuid import uuid4
 
@@ -632,7 +631,6 @@ def add_entry_field_type(
             field_model = TextField(
                 type_key=field.key,
                 value=value or "",
-                position=randint(100, 100_000),
             )
         elif field.type == FieldTypeEnum.TAGS:
             field_model = TagBoxField(
@@ -656,9 +654,6 @@ def add_entry_field_type(
             try:
                 for entry_id in entry_ids:
                     field_model.entry_id = entry_id
-                    # create random value position to avoid IntegrityError, reordering is below
-                    field_model.position = randint(100, 100_000)
-
                     session.add(field_model)
                     session.flush()