Add -Werror flag to emu compilation (#274)

tolauwae · web-flow · commit 25409cca8256 · 2024-11-25T15:06:49.000+01:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -64,7 +64,7 @@ if (BUILD_EMULATOR)
 
     # Set default compile flags for GCC
     if (CMAKE_COMPILER_IS_GNUCXX)
-        add_compile_options(-g -v -Wall -Wextra -Wunused -O3)
+        add_compile_options(-g -v -Wall -Wextra -Werror -Wunused -O3)
     endif (CMAKE_COMPILER_IS_GNUCXX)
 
     # WARDuino CLI
diff --git a/src/Debug/debugger.cpp b/src/Debug/debugger.cpp
@@ -954,7 +954,7 @@ void Debugger::setSnapshotPolicy(Module *m, uint8_t *interruptData) {
 
 std::optional<uint32_t> getPrimitiveBeingCalled(Module *m, uint8_t *pc_ptr) {
     if (!pc_ptr) {
-        return {};
+        return std::nullopt;
     }
 
     // TODO: Support call_indirect
@@ -966,7 +966,7 @@ std::optional<uint32_t> getPrimitiveBeingCalled(Module *m, uint8_t *pc_ptr) {
             return fidx;
         }
     }
-    return {};
+    return std::nullopt;
 }
 
 void Debugger::handleSnapshotPolicy(Module *m) {

Original file line number	Diff line number	Diff line change
`@@ -954,7 +954,7 @@ void Debugger::setSnapshotPolicy(Module m, uint8_t interruptData) {`
`954`	`954`
`955`	`955`	`std::optional<uint32_t> getPrimitiveBeingCalled(Module m, uint8_t pc_ptr) {`
`956`	`956`	`if (!pc_ptr) {`
`957`		`- return {};`
	`957`	`+ return std::nullopt;`
`958`	`958`	`}`
`959`	`959`
`960`	`960`	`// TODO: Support call_indirect`
`@@ -966,7 +966,7 @@ std::optional<uint32_t> getPrimitiveBeingCalled(Module m, uint8_t pc_ptr) {`
`966`	`966`	`return fidx;`
`967`	`967`	`}`
`968`	`968`	`}`
`969`		`- return {};`
	`969`	`+ return std::nullopt;`
`970`	`970`	`}`
`971`	`971`
`972`	`972`	`void Debugger::handleSnapshotPolicy(Module *m) {`