Skip to content

Commit 948e083

Browse files
authored
Fix checklists on CONTRIBUTING.md
1 parent 0782d28 commit 948e083

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ The standards below are non-exhaustive but I will update them when relevant.
1010

1111
## Checklist
1212

13-
[] PR contains a single logical change - Avoid bundling many changes together as they're harder to review
14-
[] Changes and basic functionality are tested
13+
- [ ] PR contains a single logical change - Avoid bundling many changes together as they're harder to review
14+
- [ ] Changes and basic functionality are tested
1515
- Open the HTML locally and verify it renders correctly and does not produce console messages (errors, warnings, logs)
1616
- If changing anything other than HTML and CSS, test a known working MIDI. I use Snow Halation, whose MIDI is at
1717
`/test/sno.mid` and TMB is at `/test/sno.tmb`. The
@@ -20,14 +20,14 @@ The standards below are non-exhaustive but I will update them when relevant.
2020
- Ensure the preview looks correct
2121
- Generate the chart and play it in TC
2222
- If adding a new feature or changing an existing one, test a MIDI that uses the feature
23-
[] Style matches existing code (See style guide below)
24-
[] Changelog is updated in the PR
23+
- [ ] Style matches existing code (See style guide below)
24+
- [ ] Changelog is updated in the PR
2525
- Increment the suffix letter for a tiny change that does not impact features, or a bugfix
2626
- Increment the minor version for a change that adds or alters a feature beyond a bugfix
2727
- I will determine when to increment the major version
28-
[] For feature contributions: Contributor is named in the footer - Add your name if it's not already there
28+
- [ ] For feature contributions: Contributor is named in the footer - Add your name if it's not already there
2929
- For bugfixes: Github will add your name to the contributors list but you do not get to appear on the page
30-
[] PR comment contains a summary of the changes and why they are being made
30+
- [ ] PR comment contains a summary of the changes and why they are being made
3131
- Example: "Fixes bug where colors with R, G, or B values under 16 could import as black"
3232
- Example: "Treats noteOn events with velocity 0 as noteOff events: Some DAWs (including Reaper) use this convention"
3333

0 commit comments

Comments
 (0)