Remove redundant .AsSpan() / casts to {ReadOnly,}Span

Author: YoshiRulz

src/BizHawk.Bizware.Graphics/D3D11/D3D11GLInterop.cs

@@ -182,7 +182,7 @@ static D3D11GLInterop()
 
 						if (vendor == Vendor.Intel)
 						{
-							if (_blacklistedIntelDeviceIds.AsSpan().Contains(adapter.Description.DeviceId))
+							if (_blacklistedIntelDeviceIds.Contains(adapter.Description.DeviceId))
 							{
 								return;
 							}

src/BizHawk.Client.Common/RomLoader.cs

@@ -557,7 +557,7 @@ private void LoadOther(
 					const string ERR_MSG_NOT_PSXEXE = "Got an .exe which is not in the PSX-EXE format!"
 						+ "\nIf you're trying to load a PE (Windows program), you need to load the unextracted disc image. See https://tasvideos.org/BizHawk/DOSBox for details." // sadly won't be clickable
 						+ "\n"; // extra blank line to separate from stacktrace below
-					if (!rom.FileData.AsSpan().StartsWith("PS-X EXE"u8)) throw new /*NoAvailableCoreException*/InvalidOperationException(ERR_MSG_NOT_PSXEXE);
+					if (!rom.FileData.StartsWith("PS-X EXE"u8)) throw new /*NoAvailableCoreException*/InvalidOperationException(ERR_MSG_NOT_PSXEXE);
 					break;
 			}
 			var cip = new CoreInventoryParameters(this)

src/BizHawk.Client.Common/lua/LuaHelperLibs/EventsLuaLibrary.cs

@@ -351,6 +351,6 @@ private string ProcessScope(string scope)
 
 		private bool HasScope(string scope)
 			=> string.IsNullOrWhiteSpace(scope)
-				|| DebuggableCore.MemoryCallbacks.AvailableScopes.AsSpan().Contains(scope);
+				|| DebuggableCore.MemoryCallbacks.AvailableScopes.Contains(scope);
 	}
 }

src/BizHawk.Client.Common/movie/import/bkm/BkmControllerAdapter.cs

@@ -134,7 +134,7 @@ public void SetControllersAsMnemonic(string mnemonic)
 					SetFromMnemonic(mnemonic.AsSpan(3));
 					break;
 				case "Dual Gameboy Controller":
-					SetFromMnemonic(mnemonic.AsSpan());
+					SetFromMnemonic(mnemonic);
 					break;
 				case "WonderSwan Controller":
 					SetFromMnemonic(mnemonic.AsSpan(1));

src/BizHawk.Common/BPSPatcher.cs

@@ -205,7 +205,7 @@ internal void DoPatch(Span<byte> rom)
 		private const string ERR_MSG_UNINIT = "uninitialised struct";
 
 		private static bool CheckCRC(ReadOnlySpan<byte> data, ReadOnlySpan<byte> reversedChecksum)
-			=> ((ReadOnlySpan<byte>) CRC32Checksum.Compute(data)).ReversedSequenceEqual(reversedChecksum);
+			=> CRC32Checksum.Compute(data).ReversedSequenceEqual(reversedChecksum);
 
 		public static bool IsBPSFile(ReadOnlySpan<byte> dataWithHeader, out BPSPayload patchStruct)
 		{

src/BizHawk.Emulation.Common/N3DSHasher.cs

@@ -382,19 +382,19 @@ private void HashNCCH(FileStream romFile, IncrementalHash md5Inc, byte[] header,
 						if ((exeFsSectionSize & 0xF) != 0)
 						{
 							var ivCopy = new byte[iv.Length];
-							iv.AsSpan().CopyTo(ivCopy);
+							iv.CopyTo(ivCopy);
 							exeFsSectionOffset &= ~0xFU;
 
 							// First decrypt these last bytes using the secondary key
 							AesCtrTransform(aes, iv, exeFsBuffer.AsSpan((int)exeFsSectionOffset, (int)(0x10 - (exeFsSectionSize & 0xF))));
 
 							// Now re-encrypt these bytes using the primary key
 							aes.Key = primaryKey;
-							ivCopy.AsSpan().CopyTo(iv);
+							ivCopy.CopyTo(iv);
 							AesCtrTransform(aes, iv, exeFsBuffer.AsSpan((int)exeFsSectionOffset, (int)(0x10 - (exeFsSectionSize & 0xF))));
 
 							// All of the padding can now be decrypted using the primary key
-							ivCopy.AsSpan().CopyTo(iv);
+							ivCopy.CopyTo(iv);
 							exeFsSectionSize += 0x10 - (exeFsSectionSize & 0xF);
 						}
 

src/BizHawk.Emulation.Cores/Computers/AmstradCPC/Media/Disk/FloppyDisk.cs

@@ -641,7 +641,7 @@ public byte[] ActualData
 						if (size > ActualDataByteLength)
 						{
 							var buf = new byte[SectorData.Length + size - ActualDataByteLength];
-							SectorData.AsSpan().CopyTo(buf);
+							SectorData.CopyTo(buf);
 //							SectorData.AsSpan(start: 0, length: buf.Length - SectorData.Length)
 //								.CopyTo(buf.AsSpan(start: SectorData.Length));
 							buf.AsSpan(start: SectorData.Length).Fill(SectorData[SectorData.Length - 1]);

src/BizHawk.Emulation.Cores/Computers/AppleII/AppleII.ISaveRam.cs

@@ -69,7 +69,7 @@ private void LoadDelta(bool maybeDifferent)
 				}
 				else if (maybeDifferent)
 				{
-					original.AsSpan().CopyTo(current);
+					original.CopyTo(current);
 				}
 			});
 		}

src/BizHawk.Emulation.Cores/Computers/Commodore64/Cartridge/Am29F040B.cs

@@ -144,8 +144,8 @@ public void Reset()
 		_endAddress = ImageMask;
 	}
 
-	public Span<byte> Data =>
-		_data.AsSpan();
+	public Span<byte> Data
+		=> _data;
 
 	public int Peek(int addr) =>
 		_data[addr & ImageMask] & 0xFF;

src/BizHawk.Emulation.Cores/Computers/Commodore64/Cartridge/Mapper0013.cs

@@ -62,7 +62,7 @@ public Mapper0013(IEnumerable<CartridgeChip> chips)
 				var bank = new byte[BankSize];
 
 				bank.AsSpan().Fill(DummyData);
-				chip.ConvertDataToBytes().CopyTo(bank.AsSpan());
+				chip.ConvertDataToBytes().CopyTo(bank);
 
 				_banks[chip.Bank] = bank;