Use Span<T>.Contains for arrays

Author: YoshiRulz

src/BizHawk.Bizware.Graphics/D3D11/D3D11GLInterop.cs

@@ -6,8 +6,6 @@
 using Vortice.Direct3D11;
 using Vortice.DXGI;
 
-using BizHawk.Common.CollectionExtensions;
-
 using static SDL2.SDL;
 
 namespace BizHawk.Bizware.Graphics
@@ -184,7 +182,7 @@ static D3D11GLInterop()
 
 						if (vendor == Vendor.Intel)
 						{
-							if (_blacklistedIntelDeviceIds.Contains(adapter.Description.DeviceId))
+							if (_blacklistedIntelDeviceIds.AsSpan().Contains(adapter.Description.DeviceId))
 							{
 								return;
 							}

src/BizHawk.Client.Common/lua/LuaHelperLibs/EventsLuaLibrary.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using System.ComponentModel;
 
 using NLua;
@@ -351,8 +350,7 @@ private string ProcessScope(string scope)
 		}
 
 		private bool HasScope(string scope)
-		{
-			return string.IsNullOrWhiteSpace(scope) || DebuggableCore.MemoryCallbacks.AvailableScopes.Contains(scope);
-		}
+			=> string.IsNullOrWhiteSpace(scope)
+				|| DebuggableCore.MemoryCallbacks.AvailableScopes.AsSpan().Contains(scope);
 	}
 }

src/BizHawk.Common/Extensions/CollectionExtensions.cs

@@ -246,13 +246,6 @@ public static IEnumerable<T[]> Chunk<T>(this IEnumerable<T> source, int size)
 			yield return (Start: numbers[blockStart], Count: i - blockStart); // `count` arg will be 0 if the whole list is contiguous
 		}
 
-		/// <remarks>
-		/// Contains method for arrays which does not need Linq, but rather uses Array.IndexOf
-		/// similar to <see cref="ICollection{T}.Contains">ICollection's Contains</see>
-		/// </remarks>
-		public static bool Contains<T>(this T[] array, T value)
-			=> Array.IndexOf(array, value) >= 0;
-
 		/// <returns>
 		/// portion of <paramref name="dest"/> that was written to,
 		/// unless either span is empty, in which case the other reference is returned<br/>

src/BizHawk.Emulation.Cores/Consoles/Nintendo/NDS/NDSFirmware.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using System.Runtime.InteropServices;
 
 using BizHawk.Common;
@@ -66,7 +65,7 @@ private static unsafe void CheckDecryptedCodeChecksum(
 			try
 			{
 				var hash = SHA1Checksum.ComputeDigestHex(Util.UnsafeSpanFromPointer(decryptedFw, decrypedFwLen));
-				if (!_goodHashes.Contains(hash))
+				if (!_goodHashes.AsSpan().Contains(hash))
 				{
 					warningCallback($"Potentially bad firmware dump! Decrypted hash {hash} does not match known good dumps.");
 				}

src/BizHawk.Emulation.Cores/Waterbox/NymaCore.Controller.ButtonNameOverrides.cs

@@ -1,14 +1,13 @@
 using System.Collections.Generic;
 using System.Globalization;
-using System.Linq;
 using System.Text.RegularExpressions;
 
 namespace BizHawk.Emulation.Cores.Waterbox
 {
 	public abstract partial class NymaCore
 	{
 		private static bool IsRomanNumeral(string str)
-			=> new[] {"I", "II", "III", "IV", "V", "VI"}.Contains(str);
+			=> str is "I" or "II" or "III" or "IV" or "V" or "VI";
 
 		private static readonly Dictionary<string, string> ButtonNameOverrides = new Dictionary<string, string>
 		{