Comment out Util.UnsafeSpanFromPointer<T>

see 245f0e2

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs

@@ -385,7 +385,7 @@ private bool GetNcchNormalKeysFunc(IntPtr primary_key_y, byte secondary_key_x_sl
 				}
 
 				var programId = BinaryPrimitives.ReadUInt64LittleEndian(
-					Util.UnsafeSpanFromPointer<byte>(ptr: optional_program_id, count: 8));
+					Util.UnsafeSpanFromPointer(ptr: optional_program_id, length: 8));
 
 				FirmwareID seeddbFWID = new("3DS", "seeddb");
 				using BinaryReader seeddb = new(GetFirmware(seeddbFWID));

src/BizHawk.Common/Util.cs

@@ -293,17 +293,19 @@ public static unsafe Span<byte> UnsafeSpanFromPointer(IntPtr ptr, int length)
 			return new(pointer: ptr.ToPointer(), length: length);
 		}
 
+#if false // unused
 		/// <summary>
 		/// creates span over <paramref name="count"/><c> * sizeof(</c><typeparamref name="T"/><c>)</c> octets
 		/// starting at <paramref name="ptr"/>
 		/// </summary>
-		/// <remarks>uses native endianness</remarks>
+		/// <remarks>uses native endianness and <paramref name="ptr"/> must be aligned (else UB)</remarks>
 		[MethodImpl(MethodImplOptions.AggressiveInlining)]
-		public static unsafe Span<T> UnsafeSpanFromPointer<T>(IntPtr ptr, int count)
+		public static unsafe Span<T> UnsafeSpanFromPointerAligned<T>(IntPtr ptr, int count)
 			where T : unmanaged
 		{
 			return new(pointer: ptr.ToPointer(), length: count * sizeof(T));
 		}
+#endif
 
 		public static void WriteByteBuffer(this BinaryWriter bw, byte[]? data)
 		{