Skip to content

Fix Dutch (NL) translations + filename #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Dutch (NL) translations + filename #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...tions/ResetPasswordBundle+intl-icu.nl.xlf → ...s/translations/ResetPasswordBundle.nl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@
<body>
<trans-unit id="1">
<source>%count% year|%count% years</source>
<target>{count, plural, =0 {0 jaar} one {1 jaar} other {# jaren}}</target>
<target>%count% jaar|%count% jaar</target>
Copy link
Member

@bocharsky-bw bocharsky-bw Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct translation should be this one?

Suggested change
<target>%count% jaar|%count% jaar</target>
<target>%count% jaar|%count% jaren</target>

Copy link
Author

@RobQuistNL RobQuistNL Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yes, and no. I actually had to change this back to "jaar" after accidentally putting in "jaren" - plural of "jaar" is indeed "jaren", but when we (being, the Dutch) say something about multiple years, there's some weird rules going on. We say "18 jaar" and not "18 jaren".

"That took 2 years and 1 months" will become "Dat duurde 2 jaar en 4 maanden". If we then say "Many years" we would say "Veel jaren" instead of "Veel jaar"... I don't know why or what this is called - I'm no linguist, but I'm native Dutch :+)

Copy link
Author

@RobQuistNL RobQuistNL Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, even "thousands of years" would be "duizenden jaren" while "2000 years old" would be "2000 jaar oud". "2000 jaren oud" also works, sounds less strange than "3 jaren", but also sounds off to me. I'd be happy to hear if some linguist has answers about this phenomenon :+)

</trans-unit>
<trans-unit id="2">
<source>%count% month|%count% months</source>
<target>{count, plural, =0 {0 maanden} one {1 maand} other {# maanden}}</target>
<target>%count% maand|%count% maanden</target>
</trans-unit>
<trans-unit id="3">
<source>%count% day|%count% days</source>
<target>{count, plural, =0 {0 dagen} one {1 dag} other {# dagen}}</target>
<target>%count% dag|%count% dagen</target>
</trans-unit>
<trans-unit id="4">
<source>%count% hour|%count% hours</source>
<target>{count, plural, =0 {0 uur} one {1 uur} other {# uren}}</target>
<target>%count% uur|%count% uren</target>
</trans-unit>
<trans-unit id="5">
<source>%count% minute|%count% minutes</source>
<target>{count, plural, =0 {0 minuten} one {1 minuut} other {# minuten}}</target>
<target>%count% minuut|%count% minuten</target>
</trans-unit>
<trans-unit id="6">
<source>There was a problem validating your password reset request</source>
Expand Down