Implement tagNames methods

Fix implementation of tag methods

Author: mattt

Sources/Git/Extensions/Array+Extensions.swift

@@ -2,6 +2,10 @@ import Clibgit2
 import Foundation
 
 extension Array where Element == String {
+    init(_ git_strarray: git_strarray) {
+        self.init((0..<git_strarray.count).map { String(validatingUTF8: git_strarray.strings[$0]!)! })
+    }
+    
     @discardableResult
     func withGitStringArray<T>(_ body: (git_strarray) throws -> T) rethrows -> T {
         let cStrings = UnsafeMutablePointer<UnsafeMutablePointer<CChar>?>.allocate(capacity: count)

Sources/Git/Remote.swift

@@ -142,9 +142,3 @@ extension Optional /*: internal RawRepresentable */ where Wrapped == Remote.Fetc
         }
     }
 }
-
-fileprivate extension Array where Element == String {
-    init(_ git_strarray: git_strarray) {
-        self.init((0..<git_strarray.count).map { String(validatingUTF8: git_strarray.strings[$0]!)! })
-    }
-}

Sources/Git/Repository.swift

@@ -210,18 +210,31 @@ public final class Repository {
 
     /// Creates a lightweight tag.
     public func tag(name: String, target: Object, force: Bool = false) throws {
-        let name = try Reference.normalize(name: name)
         let _ = try Object.ID { oid in
             try attempt { git_tag_create_lightweight(oid, self.pointer, name, target.pointer, force ? 1 : 0) }
         }
     }
 
     /// Creates an annotated tag.
     public func tag(name: String, target: Object, tagger: Signature? = nil, message: String, force: Bool = false) throws {
-        let name = try Reference.normalize(name: name)
         var signature = try (tagger ?? Signature.default(for: self)).rawValue
         let _ = try Object.ID { oid in
             try attempt { git_tag_create(oid, self.pointer, name, target.pointer, &signature, message, force ? 1 : 0) }
         }
     }
+
+    public func tagNames() throws -> [String] {
+        let pointer = UnsafeMutablePointer<git_strarray>.allocate(capacity: 1)
+        defer { pointer.deallocate() }
+        try attempt { git_tag_list(pointer, self.pointer) }
+        return Array(pointer.pointee)
+    }
+
+    public func tagNames(matching pattern: String) throws -> [String] {
+        let pointer = UnsafeMutablePointer<git_strarray>.allocate(capacity: 1)
+        defer { pointer.deallocate() }
+//        let pattern = try Reference.normalize(name: pattern, format: .refspecPattern)
+        try attempt { git_tag_list_match(pointer, pattern, self.pointer) }
+        return Array(pointer.pointee)
+    }
 }

Tests/GitTests/GitTests.swift

@@ -100,6 +100,11 @@ final class GitTests: XCTestCase {
 
         let note = try commit.add(note: #"{"test": true }"#, author: signature, committer: signature)
         XCTAssertNotNil(note?.message, #"{"test": true }"#)
+
+        try repository.tag(name: "0.0.1", target: commit)
+        let names = try repository.tagNames()
+        XCTAssertFalse(names.isEmpty)
+        XCTAssert(names.contains("0.0.1"))
     }
 }