Skip to content

Conversation

@dhruv-shah-sumo
Copy link
Collaborator

@dhruv-shah-sumo dhruv-shah-sumo commented Nov 6, 2025

OSC-1200

Supports behavior for autoscaling for otel logs/metrics/traces collector.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Integration tests added or modified for major features

@dhruv-shah-sumo dhruv-shah-sumo requested a review from a team as a code owner November 6, 2025 04:29
@dhruv-shah-sumo dhruv-shah-sumo force-pushed the dhruv/hpa-otel-implementation branch from 78f1c1d to 04b8ca0 Compare November 6, 2025 04:42
@Gourav2906 Gourav2906 marked this pull request as draft November 6, 2025 05:35
@dhruv-shah-sumo dhruv-shah-sumo force-pushed the dhruv/hpa-otel-implementation branch 4 times, most recently from 4948819 to d69b673 Compare November 19, 2025 12:01
@dhruv-shah-sumo dhruv-shah-sumo force-pushed the dhruv/hpa-otel-implementation branch 5 times, most recently from ad28d5c to b2f64ad Compare November 19, 2025 14:21
OSC-1200

Signed-off-by: Dhruv Shah <dhruv.shah@sumologic.com>
@dhruv-shah-sumo dhruv-shah-sumo force-pushed the dhruv/hpa-otel-implementation branch from b2f64ad to 7e8cf2a Compare November 19, 2025 14:27
@dhruv-shah-sumo dhruv-shah-sumo marked this pull request as ready for review November 19, 2025 14:29
@Gourav2906 Gourav2906 requested a review from Copilot November 20, 2025 05:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Horizontal Pod Autoscaler (HPA) behavior configuration support to the OpenTelemetry collectors in the Sumo Logic Kubernetes collection. The changes enable customizable scale-up and scale-down policies for autoscaling workloads.

Key Changes

  • Added behavior field to autoscaling configuration across all collector types (logs, metrics, traces, and instrumentation)
  • Introduced integration test to verify HPA configuration and functionality
  • Updated Helm templates to conditionally render HPA behavior settings when specified

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
deploy/helm/sumologic/values.yaml Added behavior: {} default values for autoscaling configuration in metrics collector, instrumentation, logs, metrics metadata, and traces gateway
deploy/helm/sumologic/templates/*/hpa.yaml Updated HPA templates to conditionally render behavior configuration using toYaml
tests/integration/helm_ot_hpa_test.go New integration test to validate HPA configuration across all collectors
tests/integration/features.go Added GetHPAFeature function to create test feature for HPA validation
tests/integration/internal/stepfuncs/assess_funcs.go Added WaitUntilHPAConfigured and WaitUntilHPAPresent functions to verify HPA configuration
tests/integration/values/values_helm_ot_hpa.yaml Test values file with HPA behavior configuration for all collectors
tests/helm/testdata/goldenfile/metrics_collector_otc/* Updated golden files to include HPA behavior in test output
deploy/helm/sumologic/README.md Documented the new behavior configuration option for all autoscaling sections
.changelog/4026.added.txt Added changelog entry for the feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@jagan2221 jagan2221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruv-shah-sumo IT's are fine.Hope we have also ensured in local by configuring behaviour parameter for all supported HPA configs and ensured that created HPA picks those supplied behaviour parameters.

@dhruv-shah-sumo
Copy link
Collaborator Author

@dhruv-shah-sumo IT's are fine.Hope we have also ensured in local by configuring behaviour parameter for all supported HPA configs and ensured that created HPA picks those supplied behaviour parameters.

Yes, I verified it locally. Used kubectl get hpa to validate the configured values. Also validated the pods getting scaled up and scaled down manually.

Will address the readme comments soon.

dhruv-shah-sumo and others added 4 commits November 20, 2025 14:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…telemetrycollector.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dhruv Shah <dhruv.shah@sumologic.com>
@dhruv-shah-sumo dhruv-shah-sumo force-pushed the dhruv/hpa-otel-implementation branch from d1e7fd3 to 0d666e6 Compare November 20, 2025 10:24
@dhruv-shah-sumo dhruv-shah-sumo merged commit a637e9c into main Nov 20, 2025
79 checks passed
@dhruv-shah-sumo dhruv-shah-sumo deleted the dhruv/hpa-otel-implementation branch November 20, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants