-
Notifications
You must be signed in to change notification settings - Fork 185
feat(HPA): Adds autoscaling config #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
78f1c1d to
04b8ca0
Compare
4948819 to
d69b673
Compare
ad28d5c to
b2f64ad
Compare
OSC-1200 Signed-off-by: Dhruv Shah <dhruv.shah@sumologic.com>
b2f64ad to
7e8cf2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Horizontal Pod Autoscaler (HPA) behavior configuration support to the OpenTelemetry collectors in the Sumo Logic Kubernetes collection. The changes enable customizable scale-up and scale-down policies for autoscaling workloads.
Key Changes
- Added
behaviorfield to autoscaling configuration across all collector types (logs, metrics, traces, and instrumentation) - Introduced integration test to verify HPA configuration and functionality
- Updated Helm templates to conditionally render HPA behavior settings when specified
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/helm/sumologic/values.yaml | Added behavior: {} default values for autoscaling configuration in metrics collector, instrumentation, logs, metrics metadata, and traces gateway |
| deploy/helm/sumologic/templates/*/hpa.yaml | Updated HPA templates to conditionally render behavior configuration using toYaml |
| tests/integration/helm_ot_hpa_test.go | New integration test to validate HPA configuration across all collectors |
| tests/integration/features.go | Added GetHPAFeature function to create test feature for HPA validation |
| tests/integration/internal/stepfuncs/assess_funcs.go | Added WaitUntilHPAConfigured and WaitUntilHPAPresent functions to verify HPA configuration |
| tests/integration/values/values_helm_ot_hpa.yaml | Test values file with HPA behavior configuration for all collectors |
| tests/helm/testdata/goldenfile/metrics_collector_otc/* | Updated golden files to include HPA behavior in test output |
| deploy/helm/sumologic/README.md | Documented the new behavior configuration option for all autoscaling sections |
| .changelog/4026.added.txt | Added changelog entry for the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deploy/helm/sumologic/templates/metrics/collector/otelcol/opentelemetrycollector.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv-shah-sumo IT's are fine.Hope we have also ensured in local by configuring behaviour parameter for all supported HPA configs and ensured that created HPA picks those supplied behaviour parameters.
Yes, I verified it locally. Used kubectl get hpa to validate the configured values. Also validated the pods getting scaled up and scaled down manually. Will address the readme comments soon. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…telemetrycollector.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dhruv Shah <dhruv.shah@sumologic.com>
d1e7fd3 to
0d666e6
Compare
OSC-1200
Supports behavior for autoscaling for otel logs/metrics/traces collector.
Checklist