Mark Summary and Details as block items (#1276)

arjanmels · Arjan Mels · web-flow · commit a380ebc4cbf1 · 2023-05-26T06:52:16.000-06:00
Co-authored-by: Arjan Mels &lt;github@mels.email&gt;
diff --git a/lib/src/builtins/styled_element_builtin.dart b/lib/src/builtins/styled_element_builtin.dart
@@ -399,6 +399,11 @@ class StyledElementBuiltIn extends HtmlExtension {
           verticalAlign: VerticalAlign.sub,
         );
         break;
+      case "summary":
+        styledElement.style = Style(
+          display: Display.block,
+        );
+        break;
       case "sup":
         styledElement.style = Style(
           fontSize: FontSize.smaller,
diff --git a/test/whitespace_test.dart b/test/whitespace_test.dart
@@ -66,6 +66,32 @@ void main() {
     },
   );
 
+  //See https://github.com/Sub6Resources/flutter_html/issues/1275
+  testWidgets(
+    "test that extra newlines aren't added unnecessarily for details/summary tags",
+    (tester) async {
+      final tree = await generateStyledElementTreeFromHtml(
+        tester,
+        html: """
+<!DOCTYPE html>
+<html>
+<body>
+<details>
+  <summary><h1>Header</h1></summary>
+  <p>These are the details.</p>
+</details>
+</body>
+</html>
+""",
+      );
+
+      expect(
+          tree.getWhitespace(),
+          equals(
+              "<body><details><summary><h1>Header</h1></summary><p>These◦are◦the◦details.</p></details></body>"));
+    },
+  );
+
   // See https://github.com/Sub6Resources/flutter_html/issues/1251
   testWidgets(
     'test that preserved whitespace is actually preserved',
