Bugfix: continue instead of break on excess key in struct / object.

Fixes #27.

Author: StringEpsilon

CHANGELOG.md

@@ -1,14 +1,15 @@
-# 1.0
+# 1.0 (Future)
 
 **Deserialization:**
 - Added `string Serialize(object? input, PhpSerializiationOptions? options = null)` to `PhpSerialization` so the target type can be specified at run time.
 - `PhpSerialization` (entry point of the library) is now null reference aware, aiding library consumers in caching `NullReferenceException`.
 - `PhpSerialization` throws `ArgumentOutOfRangeException` instead of the more generalised `ArgumentException`
 - Bugfix: "INF" and "-INF" would not be handled correctly when using explicit typing (`Deserialize<T>`) for some target types.
 - Bugfix: Properly set classname when deserializing with explicit types that implement IPhpObject.
+- Bugfix: With the AllowExcessKeys, the deserialization of the given struct or object would abort when an excess key was encountered, leaving the properties after the excess key unassigned. See issue [#27](https://github.com/StringEpsilon/PhpSerializerNET/issues/27).
 - Performance tweaks:
 	- Minor improvements on memory use during deserialization.
-	- Improved performance for deserializing Double and Integer values with explicit types.	
+	- Improved performance for deserializing Double and Integer values with explicit types.
 
 **General:**
 * Bugfix: `PhpSerialization.ClearTypeCache()` was not exposed.

PhpSerializerNET.Test/Deserialize/Options/AllowExcessKeys.cs

@@ -56,5 +56,16 @@ public void Object_ThrowsWithOptionDisabled() {
 			));
 			Assert.AreEqual("Could not bind the key \"BString\" to object of type SimpleClass: No such property.", ex.Message);
 		}
+
+		[TestMethod]
+		public void Enabled_ProperlyAssignsAllKeys() {
+			// Explicit test for issue #27.
+			var result = PhpSerialization.Deserialize<SimpleClass>(
+				"O:11:\"SimpleClass\":3:{s:1:\"_\";b:0;s:4:\"True\";b:1;s:5:\"False\";b:0;}",
+				new PhpDeserializationOptions() { AllowExcessKeys = true }
+			);
+			Assert.AreEqual(true, result.True);
+			Assert.AreEqual(false, result.False);
+		}
 	}
 }

PhpSerializerNET/PhpDeserializer.cs

@@ -40,7 +40,7 @@ public object Deserialize(Type targetType) {
 		}
 
 		public T Deserialize<T>() {
-			return (T) this.Deserialize(typeof(T));
+			return (T)this.Deserialize(typeof(T));
 		}
 
 		/// <summary>
@@ -323,7 +323,7 @@ private object MakeStruct(Type targetType, PhpSerializeToken token) {
 							$"Could not bind the key \"{token.Children[i].Value}\" to struct of type {targetType.Name}: No such field."
 						);
 					}
-					break;
+					continue;
 				}
 				if (fields[fieldName] != null) {
 					var field = fields[fieldName];
@@ -363,7 +363,7 @@ private object MakeObject(Type targetType, PhpSerializeToken token) {
 							$"Could not bind the key \"{token.Children[i].Value}\" to object of type {targetType.Name}: No such property."
 						);
 					}
-					break;
+					continue;
 				}
 				var property = properties[propertyName];
 				if (property != null) { // null if PhpIgnore'd