Performance: Allow caching of enum field information.

Author: StringEpsilon

CHANGELOG.md

@@ -1,5 +1,6 @@
 # vNext
 - Added support for PhpProperty on enums, allowing consumers to specify different field names
+- Performance: Cache enum field information with `TypeCacheFlag.PropertyInfo`.
 
 # 1.0.0
 

PhpSerializerNET/PhpDeserializer.cs

@@ -22,6 +22,7 @@ internal class PhpDeserializer {
 		private static readonly Dictionary<Type, Dictionary<string, PropertyInfo>> PropertyInfoCache = new();
 
 		private static Dictionary<Type, Dictionary<string, FieldInfo>> FieldInfoCache { get; set; } = new();
+		private static Dictionary<Type, Dictionary<string, FieldInfo>> EnumInfoCache { get; set; } = new();
 
 		public PhpDeserializer(string input, PhpDeserializationOptions options) {
 			_options = options;
@@ -58,6 +59,7 @@ public static void ClearTypeCache() {
 		/// </summary>
 		public static void ClearPropertyInfoCache() {
 			PropertyInfoCache.Clear();
+			EnumInfoCache.Clear();
 		}
 
 		private object DeserializeToken(PhpSerializeToken token) {
@@ -254,16 +256,32 @@ private object DeserializeTokenFromSimpleType(Type givenType, PhpSerializeToken
 					return Enum.Parse(targetType, token.Value);
 				}
 
-				var foundFieldInfo = targetType
-					.GetFields()
-					.Select(fieldInfo => new { fieldInfo, phpPropertyAttribute = fieldInfo.GetCustomAttribute<PhpPropertyAttribute>() })
-					.FirstOrDefault(c => c.fieldInfo.Name == token.Value || c.phpPropertyAttribute != null && c.phpPropertyAttribute.Name == token.Value)
-					?.fieldInfo;
+
+				FieldInfo foundFieldInfo = null;
+				if (this._options.TypeCache.HasFlag(TypeCacheFlag.PropertyInfo)) {
+					if (!EnumInfoCache.ContainsKey(targetType)) {
+						EnumInfoCache.Add(targetType, new());
+					}
+					if (EnumInfoCache[targetType].ContainsKey(token.Value)) {
+						foundFieldInfo = EnumInfoCache[targetType][token.Value];
+					}
+				}
 
 				if (foundFieldInfo == null) {
-						throw new DeserializationException(
-							$"Exception encountered while trying to assign '{token.Value}' to type '{targetType.Name}'. " +
-							$"The value could not be matched to an enum member.");
+					foundFieldInfo = targetType
+						.GetFields()
+						.Select(fieldInfo => new { fieldInfo, phpPropertyAttribute = fieldInfo.GetCustomAttribute<PhpPropertyAttribute>() })
+						.FirstOrDefault(c => c.fieldInfo.Name == token.Value || c.phpPropertyAttribute != null && c.phpPropertyAttribute.Name == token.Value)
+						?.fieldInfo;
+					if (this._options.TypeCache.HasFlag(TypeCacheFlag.PropertyInfo)) {
+						EnumInfoCache[targetType].Add(token.Value, foundFieldInfo);
+					}
+				}
+
+				if (foundFieldInfo == null) {
+					throw new DeserializationException(
+						$"Exception encountered while trying to assign '{token.Value}' to type '{targetType.Name}'. " +
+						$"The value could not be matched to an enum member.");
 				}
 
 				return foundFieldInfo.GetRawConstantValue();