Skip to content

Commit ace394b

Browse files
committed
Enable seq feature gate for value-bag dependency
1 parent a619332 commit ace394b

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

spdlog/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ serde_json = { version = "1.0.120", optional = true }
6161
spdlog-internal = { version = "=0.2.0", path = "../spdlog-internal", optional = true }
6262
spdlog-macros = { version = "=0.3.0", path = "../spdlog-macros" }
6363
thiserror = "2.0.0"
64-
value-bag = { version = "1.11.1", features = ["owned", "inline-i128"] }
64+
value-bag = { version = "1.11.1", features = ["owned", "inline-i128", "seq"] }
6565

6666
[target.'cfg(windows)'.dependencies]
6767
winapi = { version = "0.3.9", features = ["consoleapi", "debugapi", "handleapi", "processenv", "processthreadsapi", "winbase", "wincon"] }

spdlog/src/kv.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
//! | `:serde` | Pass the value using [`serde::Serialize`] trait, crate feature `serde` is required |
5050
//!
5151
//! ```
52+
//! # use std::collections::HashSet;
5253
//! # use spdlog::prelude::*;
5354
//! # fn main() -> Result<(), Box<dyn std::error::Error>> {
5455
//! # struct Url;
@@ -63,7 +64,7 @@
6364
//! // ^ Pass the value using `Display` trait
6465
//! // ^^^^ Shorthand syntax, equivalent to `url: = url`
6566
//!
66-
//! let orders = vec!["coffee", "pizza", "soup"];
67+
//! let orders = HashSet::from(["coffee", "pizza", "soup"]);
6768
//! info!("order received", kv: { orders:? });
6869
//! // ^^ Pass the value using `Debug` trait
6970
//! // ^^^^^^^^ Shorthand syntax, equivalent to `orders:? = orders`

spdlog/src/log_macros.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,9 @@ mod tests {
397397
"3" => assert_eq!(value.to_string(), "1"),
398398
"4" => assert_eq!(value.to_string(), "1"),
399399
"5" => assert_eq!(value.to_string(), "[1, 2]"),
400-
"6" => assert_eq!(value.to_string(), "Data { i: 1, v: [1, 2] }"),
400+
"6" => assert_eq!(value.to_string(), "[1, 2]"),
401401
"7" => assert_eq!(value.to_string(), "Data { i: 1, v: [1, 2] }"),
402+
"8" => assert_eq!(value.to_string(), "Data { i: 1, v: [1, 2] }"),
402403
_ => panic!(),
403404
}
404405
Ok(())
@@ -431,19 +432,21 @@ mod tests {
431432
info!(logger: asserter, "4", kv: { v:? = 1 });
432433
info!(logger: asserter, "4", kv: { v:? = &1 });
433434

435+
info!(logger: asserter, "5", kv: { v = vec![1, 2] });
436+
434437
#[cfg(feature = "sval")]
435-
info!(logger: asserter, "5", kv: { v:sval = vec![1, 2] });
438+
info!(logger: asserter, "6", kv: { v:sval = vec![1, 2] });
436439
#[cfg(feature = "sval")]
437-
info!(logger: asserter, "5", kv: { v:sval = &vec![1, 2] });
440+
info!(logger: asserter, "6", kv: { v:sval = &vec![1, 2] });
438441

439442
#[cfg(feature = "sval")]
440-
info!(logger: asserter, "6", kv: { v:sval = data });
443+
info!(logger: asserter, "7", kv: { v:sval = data });
441444
#[cfg(feature = "sval")]
442-
info!(logger: asserter, "6", kv: { v:sval = &data });
445+
info!(logger: asserter, "7", kv: { v:sval = &data });
443446

444447
#[cfg(feature = "serde")]
445-
info!(logger: asserter, "7", kv: { v:serde = data });
448+
info!(logger: asserter, "8", kv: { v:serde = data });
446449
#[cfg(feature = "serde")]
447-
info!(logger: asserter, "7", kv: { v:serde = &data });
450+
info!(logger: asserter, "8", kv: { v:serde = &data });
448451
}
449452
}

0 commit comments

Comments
 (0)