Skip to content

Commit e58c5b1

Browse files
committed
work
1 parent 309b3de commit e58c5b1

File tree

2 files changed

+16
-48
lines changed

2 files changed

+16
-48
lines changed

src/main/java/org/woehlke/java/simpleworklist/domain/meso/task/TaskLifecycleServiceImpl.java

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -85,29 +85,21 @@ public Task addToRootProject( @Valid Task task) {
8585
@Override
8686
@Transactional(propagation = Propagation.REQUIRED, readOnly = true)
8787
public long getMaxOrderIdTaskState(TaskState taskState, Context context) {
88-
Task task = taskService.findTopByTaskStateAndContextOrderByOrderIdTaskStateDesc(
89-
taskState,
90-
context
91-
);
88+
Task task = taskService.findTopByTaskStateAndContextOrderByOrderIdTaskStateDesc(taskState, context);
9289
return (task==null) ? 0 : task.getOrderIdTaskState();
9390
}
9491

9592
@Override
9693
@Transactional(propagation = Propagation.REQUIRED, readOnly = true)
97-
public long getMaxOrderIdProject( Project project,Context context) {
98-
Task task = taskService.findTopByProjectAndContextOrderByOrderIdProjectDesc(
99-
project,
100-
context
101-
);
94+
public long getMaxOrderIdProject(Project project,Context context) {
95+
Task task = taskService.findTopByProjectAndContextOrderByOrderIdProjectDesc(project,context);
10296
return (task==null) ? 0 : task.getOrderIdProject();
10397
}
10498

10599
@Override
106100
@Transactional(propagation = Propagation.REQUIRED, readOnly = true)
107-
public long getMaxOrderIdProjectRoot( Context context) {
108-
Task task = taskService.findTopByProjectIsNullAndContextOrderByOrderIdProjectDesc(
109-
context
110-
);
101+
public long getMaxOrderIdProjectRoot(Context context) {
102+
Task task = taskService.findTopByProjectIsNullAndContextOrderByOrderIdProjectDesc(context);
111103
return (task==null) ? 0 : task.getOrderIdProject();
112104
}
113105

src/main/java/org/woehlke/java/simpleworklist/domain/meso/task/TaskMoveServiceImpl.java

Lines changed: 11 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@ public Task moveTaskToAnotherProject( @Valid Task task, @Valid Project project)
4545
boolean okContext = task.hasSameContextAs(project);
4646
if(okContext) {
4747
task.moveTaskToAnotherProject(project);
48-
long maxOrderIdProject = taskLifecycleService.getMaxOrderIdProject(
49-
task.getProject(),
50-
task.getContext()
51-
);
48+
long maxOrderIdProject = taskLifecycleService.getMaxOrderIdProject(task.getProject(),task.getContext());
5249
task.setOrderIdProject(++maxOrderIdProject);
5350
taskService.saveAndFlush(task);
5451
}
@@ -59,9 +56,7 @@ public Task moveTaskToAnotherProject( @Valid Task task, @Valid Project project)
5956
@Override
6057
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
6158
public Task moveTaskToInbox(Task task) {
62-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
63-
TaskState.INBOX,
64-
task.getContext()
59+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.INBOX, task.getContext()
6560
);
6661
task.moveToInbox();
6762
task.setOrderIdTaskState(++newOrderIdTaskState);
@@ -74,10 +69,7 @@ public Task moveTaskToInbox(Task task) {
7469
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
7570
public Task moveTaskToToday(Task task) {
7671
Date now = new Date();
77-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
78-
TaskState.TODAY,
79-
task.getContext()
80-
);
72+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.TODAY,task.getContext());
8173
task.moveToToday();
8274
task.setOrderIdTaskState(++newOrderIdTaskState);
8375
task = taskService.saveAndFlush(task);
@@ -88,10 +80,7 @@ public Task moveTaskToToday(Task task) {
8880
@Override
8981
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
9082
public Task moveTaskToNext(Task task) {
91-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
92-
TaskState.NEXT,
93-
task.getContext()
94-
);
83+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.NEXT,task.getContext());
9584
task.moveToNext();
9685
task.setOrderIdTaskState(++newOrderIdTaskState);
9786
task = taskService.saveAndFlush(task);
@@ -102,10 +91,7 @@ public Task moveTaskToNext(Task task) {
10291
@Override
10392
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
10493
public Task moveTaskToWaiting(Task task) {
105-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
106-
TaskState.WAITING,
107-
task.getContext()
108-
);
94+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.WAITING,task.getContext());
10995
task.moveToWaiting();
11096
task.setOrderIdTaskState(++newOrderIdTaskState);
11197
task = taskService.saveAndFlush(task);
@@ -116,10 +102,7 @@ public Task moveTaskToWaiting(Task task) {
116102
@Override
117103
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
118104
public Task moveTaskToSomeday(Task task) {
119-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
120-
TaskState.SOMEDAY,
121-
task.getContext()
122-
);
105+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.SOMEDAY,task.getContext());
123106
task.moveToSomeday();
124107
task.setOrderIdTaskState(++newOrderIdTaskState);
125108
task = taskService.saveAndFlush(task);
@@ -130,9 +113,7 @@ public Task moveTaskToSomeday(Task task) {
130113
@Override
131114
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
132115
public Task moveTaskToFocus(Task task) {
133-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
134-
TaskState.FOCUS,
135-
task.getContext()
116+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.FOCUS,task.getContext()
136117
);
137118
task.moveToFocus();
138119
task.setOrderIdTaskState(++newOrderIdTaskState);
@@ -144,9 +125,7 @@ public Task moveTaskToFocus(Task task) {
144125
@Override
145126
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
146127
public Task moveTaskToCompleted(Task task) {
147-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
148-
TaskState.COMPLETED,
149-
task.getContext()
128+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.COMPLETED,task.getContext()
150129
);
151130
task.moveToCompletedTasks();
152131
task.setOrderIdTaskState(++newOrderIdTaskState);
@@ -158,10 +137,7 @@ public Task moveTaskToCompleted(Task task) {
158137
@Override
159138
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
160139
public Task moveTaskToTrash(Task task) {
161-
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(
162-
TaskState.TRASH,
163-
task.getContext()
164-
);
140+
long newOrderIdTaskState = taskLifecycleService.getMaxOrderIdTaskState(TaskState.TRASH, task.getContext());
165141
task.moveToTrash();
166142
task.setOrderIdTaskState(++newOrderIdTaskState);
167143
task = taskService.saveAndFlush(task);
@@ -189,14 +165,14 @@ public void moveAllCompletedToTrash( Context context) {
189165
@Override
190166
@Transactional(propagation = Propagation.REQUIRES_NEW, readOnly = false)
191167
public void emptyTrash( Context context) {
192-
List<Task> taskList = taskService.findByTaskStateAndContext(TaskState.TRASH, context);
168+
List<Task> taskList = taskService.findByTaskStateTrash(context);
193169
List<Task> taskListChanged = new ArrayList<>(taskList.size());
194170
for(Task task: taskList){
195171
task.emptyTrash();
196172
taskListChanged.add(task);
197173
}
198174
taskService.saveAll(taskListChanged);
199-
List<Task> taskListDeleted = taskService.findByTaskStateAndContext(TaskState.DELETED,context);
175+
List<Task> taskListDeleted = taskService.findByTaskStateDeleted(context);
200176
taskService.deleteAll(taskListDeleted);
201177
}
202178
}

0 commit comments

Comments
 (0)