Add missing tests

Author: tommysitu

src/main/java/io/specto/hoverfly/junit/rule/HoverflyRule.java

@@ -89,15 +89,15 @@ public class HoverflyRule extends ExternalResource {
 
     private HoverflyRule(HoverflyMode hoverflyMode, final SimulationSource simulationSource, final HoverflyConfig hoverflyConfig) {
         this.hoverflyMode = hoverflyMode;
-        this.hoverfly = new Hoverfly(hoverflyConfig, hoverflyMode);
+        hoverfly = new Hoverfly(hoverflyConfig, hoverflyMode);
         if (simulationSource != null) {
-            this.simulationSources.add(simulationSource);
+            simulationSources.add(simulationSource);
         }
     }
 
     private HoverflyRule(final Path capturePath, final HoverflyConfig hoverflyConfig) {
-        this.hoverflyMode = CAPTURE;
-        this.hoverfly = new Hoverfly(hoverflyConfig, hoverflyMode);
+        hoverflyMode = CAPTURE;
+        hoverfly = new Hoverfly(hoverflyConfig, hoverflyMode);
         this.capturePath = capturePath;
     }
 
@@ -301,8 +301,8 @@ protected void before() {
             importSimulation();
         }
 
-        if (hoverfly.getHoverflyConfig().isIncrementalCapture() && this.capturePath != null && Files.isReadable(this.capturePath)) {
-            hoverfly.simulate(SimulationSource.file(this.capturePath));
+        if (hoverfly.getHoverflyConfig().isIncrementalCapture() && capturePath != null && Files.isReadable(capturePath)) {
+            hoverfly.simulate(SimulationSource.file(capturePath));
         }
     }
 
@@ -350,10 +350,10 @@ public HoverflyMode getHoverflyMode() {
      */
     public void simulate(SimulationSource simulationSource, SimulationSource... sources) {
         checkMode(HoverflyMode::allowSimulationImport);
-        this.simulationSources = new ArrayList<>();
-        this.simulationSources.add(simulationSource);
+        simulationSources = new ArrayList<>();
+        simulationSources.add(simulationSource);
         if (sources.length > 0) {
-            this.simulationSources.addAll(Arrays.asList(sources));
+            simulationSources.addAll(Arrays.asList(sources));
         }
         hoverfly.resetState();
         importSimulation();

src/test/java/io/specto/hoverfly/junit/dsl/StubServiceBuilderTest.java

@@ -6,6 +6,8 @@
 import io.specto.hoverfly.junit.core.model.Request;
 import io.specto.hoverfly.junit.core.model.RequestFieldMatcher;
 import io.specto.hoverfly.junit.core.model.RequestResponsePair;
+import io.specto.hoverfly.junit.core.model.Response;
+import java.util.concurrent.TimeUnit;
 import org.apache.commons.lang3.builder.EqualsBuilder;
 import org.apache.commons.lang3.builder.HashCodeBuilder;
 import org.apache.commons.lang3.builder.ToStringBuilder;
@@ -540,6 +542,38 @@ public void shouldBeAbleToSetRequiredStates() {
                 entry("secondStateKey", "secondStateValue"));
     }
 
+    @Test
+    public void shouldBeAbleToSetFixedDelay() {
+
+        final RequestResponsePair pair = service("https://www.my-test.com")
+            .get("/")
+            .willReturn(response().withFixedDelay(10, TimeUnit.SECONDS))
+            .getRequestResponsePairs()
+            .iterator().next();
+
+        assertThat(pair.getResponse().getFixedDelay()).isEqualTo(10000);
+    }
+
+    @Test
+    public void shouldSetDefaultValuesForResponse() {
+
+        Response response = service("https://www.my-test.com")
+            .get("/")
+            .willReturn(response())
+            .getRequestResponsePairs()
+            .iterator().next()
+            .getResponse();
+
+        assertThat(response.getFixedDelay()).isEqualTo(0);
+        assertThat(response.getStatus()).isEqualTo(200);
+        assertThat(response.getBody()).isEmpty();
+        assertThat(response.getHeaders()).isEmpty();
+        assertThat(response.getTransitionsState()).isEmpty();
+        assertThat(response.getRemovesState()).isEmpty();
+        assertThat(response.isEncodedBody()).isFalse();
+        assertThat(response.isTemplated()).isTrue();
+    }
+
     private void assertExactMatcherForMethod(RequestMatcherBuilder builder, String method) {
         final Set<RequestResponsePair> pairs = builder.willReturn(response()).getRequestResponsePairs();
 
@@ -587,4 +621,4 @@ public String toString() {
             return ToStringBuilder.reflectionToString(this);
         }
     }
-}
+}

src/test/java/io/specto/hoverfly/ruletest/HoverflyDslWithDelayTest.java

@@ -40,7 +40,7 @@ public class HoverflyDslWithDelayTest {
 
                     .andDelay(3, TimeUnit.SECONDS).forMethod("POST"),
 
-            // Fixed delay for a particular request
+            // Fixed delay for a particular request matcher
             service("www.not-so-slow-service.com")
                     .get("/api/bookings")
                     .willReturn(success().withFixedDelay(1, TimeUnit.SECONDS))
@@ -92,7 +92,7 @@ public void shouldBeAbleToDelayRequestByHttpMethod() {
     }
 
     @Test
-    public void shouldBeAbleToAddFixedDelayPerRequest() {
+    public void shouldBeAbleToAddFixedDelayPerRequestMatcher() {
 
         // When
         StopWatch stopWatch = new StopWatch();