Skip to content

Commit 8b63305

Browse files
committed
minor update
1 parent e38187a commit 8b63305

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

kernel/include/vx_spawn.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
extern "C" {
2222
#endif
2323

24-
typedef void (*vx_spawn_tasks_cb)(uint32_t task_id, const void *arg);
24+
typedef void (*vx_spawn_tasks_cb)(uint32_t task_id, void *arg);
2525

26-
typedef void (*vx_serial_cb)(const void *arg);
26+
typedef void (*vx_serial_cb)(void *arg);
2727

2828
void vx_spawn_tasks(uint32_t num_tasks, vx_spawn_tasks_cb callback, const void * arg);
2929

30-
void vx_serial(vx_serial_cb callback, void * arg);
30+
void vx_serial(vx_serial_cb callback, const void * arg);
3131

3232
///////////////////////////////////////////////////////////////////////////////
3333

@@ -49,7 +49,7 @@ extern __thread uint32_t __local_group_id;
4949
extern uint32_t __groups_per_core;
5050
extern uint32_t __warps_per_group;
5151

52-
typedef void (*vx_kernel_func_cb)(const void *arg);
52+
typedef void (*vx_kernel_func_cb)(void *arg);
5353

5454
#define __local_mem(size) \
5555
(void*)((int8_t*)csr_read(VX_CSR_LOCAL_MEM_BASE) + __local_group_id * size)

kernel/src/vx_print.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ static void __putfloat_cb(const putfloat_arg_t* arg) {
5858
float value = arg->value;
5959
int precision = arg->precision;
6060
int ipart = (int)value;
61-
vx_putint(ipart, 10);
62-
if (precision != 0) {
63-
vx_putchar('.');
61+
vx_putint(ipart, 10);
62+
if (precision != 0) {
63+
vx_putchar('.');
6464
float frac = value - (float)ipart;
65-
float fscaled = frac * pow(10, precision);
66-
vx_putint((int)fscaled, 10);
67-
}
65+
float fscaled = frac * pow(10, precision);
66+
vx_putint((int)fscaled, 10);
67+
}
6868
}
6969

7070
static void __vprintf_cb(printf_arg_t* arg) {
@@ -90,7 +90,7 @@ int vx_vprintf(const char* format, va_list va) {
9090
arg.format = format;
9191
arg.va = &va;
9292
vx_serial((vx_serial_cb)__vprintf_cb, &arg);
93-
return arg.ret;
93+
return arg.ret;
9494
}
9595

9696
int vx_printf(const char * format, ...) {
@@ -99,7 +99,7 @@ int vx_printf(const char * format, ...) {
9999
va_start(va, format);
100100
ret = vx_vprintf(format, va);
101101
va_end(va);
102-
return ret;
102+
return ret;
103103
}
104104

105105
#ifdef __cplusplus

kernel/src/vx_spawn.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static void __attribute__ ((noinline)) process_all_tasks() {
4949
vx_spawn_tasks_cb callback = targs->callback;
5050
const void* arg = targs->arg;
5151
for (uint32_t task_id = start_task_id; task_id < end_task_id; task_id += threads_per_warp) {
52-
callback(task_id, arg);
52+
callback(task_id, (void*)arg);
5353
}
5454
}
5555

@@ -59,7 +59,7 @@ static void __attribute__ ((noinline)) process_remaining_tasks() {
5959
uint32_t thread_id = vx_thread_id();
6060
uint32_t task_id = targs->remain_tasks_offset + thread_id;
6161

62-
(targs->callback)(task_id, targs->arg);
62+
(targs->callback)(task_id, (void*)targs->arg);
6363
}
6464

6565
static void __attribute__ ((noinline)) process_all_tasks_stub() {
@@ -205,7 +205,7 @@ static void __attribute__ ((noinline)) process_all_task_groups() {
205205
blockIdx.x = group_id % gridDim.x;
206206
blockIdx.y = (group_id / gridDim.x) % gridDim.y;
207207
blockIdx.z = group_id / (gridDim.x * gridDim.y);
208-
callback(arg);
208+
callback((void*)arg);
209209
}
210210
}
211211

@@ -236,8 +236,8 @@ int vx_spawn_threads(uint32_t dimension,
236236
uint32_t num_groups = 1;
237237
uint32_t group_size = 1;
238238
for (uint32_t i = 0; i < 3; ++i) {
239-
uint32_t gd = (i < dimension) ? grid_dim[i] : 1;
240-
uint32_t bd = (i < dimension) ? block_dim[i] : 1;
239+
uint32_t gd = (grid_dim && (i < dimension)) ? grid_dim[i] : 1;
240+
uint32_t bd = (block_dim && (i < dimension)) ? block_dim[i] : 1;
241241
num_groups *= gd;
242242
group_size *= bd;
243243
gridDim.m[i] = gd;

0 commit comments

Comments
 (0)