Merge pull request #148 from gpittarelli/147-toApiFormat-preserve-structure

Preserve array/object structure of API data

Author: Duncan Rance

lib/toApiFormat.js

@@ -12,20 +12,11 @@ var excludeList = [
 ];
 
 function snakedKeyClone(source) {
-
   if (!_.isObject(source)) {
     return source;
   }
 
-  var target = {};
-
-  if (Array.isArray(source)) {
-    target = [];
-    for (var i = 0; i < source.length; i++) {
-      target.push(snakedKeyClone(source[i]));
-    }
-    return target;
-  }
+  var target = Array.isArray(source) ? [] : {};
 
   Object.keys(source).forEach(function(key) {
     target[_.snakeCase(key)] = snakedKeyClone(source[key]);
@@ -51,8 +42,10 @@ module.exports = function toApiFormat(source) {
   var target = snakedKeyClone(source);
 
   // Reinstated the un-modified objects into the target
-  pointer.walk(excludedObjects, function(val, ptr) {
-    pointer.set(target, ptr, val);
+  excludeList.forEach(function(exclusionPointer) {
+    if (pointer.has(excludedObjects, exclusionPointer)) {
+      pointer.set(target, exclusionPointer, pointer.get(excludedObjects, exclusionPointer));
+    }
   });
 
   return target;

test/spec/toApiFormat.spec.js

@@ -155,4 +155,30 @@ describe('toApiFormat', function() {
 
     done();
   });
+
+  it('should preserve objects with number properties', function(done) {
+    var testObj = {
+      array: [ 0, 1, , , , 5, 6]
+      , object: {
+        "0": 0,
+        "1": 1,
+        "5": 5,
+        "6": 6
+      }
+      , substitution_data: {
+        "0": 0,
+        "1": 1,
+        "5": 5,
+        "6": 6
+      }
+      , tags: [ 0, 1, , , , 5, 6]
+    };
+
+
+    var out = toApiFormat(_.clone(testObj));
+
+    expect(out).to.deep.equal(testObj);
+
+    done();
+  });
 });