Adds recipient list unit test to verify issue #57

Author: Chris Wilson

libs/sparkpost-lib/pom.xml

@@ -25,7 +25,7 @@
 		<dependency>
 			<groupId>org.apache.httpcomponents</groupId>
 			<artifactId>httpclient</artifactId>
-			<version>4.5.2</version>
+			<version>4.5.3</version>
 		</dependency>
 
 		<!-- the following two dependencies are required for correct jmockit operation 

libs/sparkpost-lib/src/test/java/com/sparkpost/resources/BaseResourceTest.java

@@ -0,0 +1,38 @@
+
+package com.sparkpost.resources;
+
+import org.junit.Assert;
+
+import com.sparkpost.testhelpers.StubRestConnection;
+
+public class BaseResourceTest {
+
+    protected void verifyWasGet(StubRestConnection conn) {
+        Assert.assertTrue(conn.wasGet());
+        Assert.assertFalse(conn.wasDelete());
+        Assert.assertFalse(conn.wasPut());
+        Assert.assertFalse(conn.wasPost());
+    }
+
+    protected void verifyWasPut(StubRestConnection conn) {
+        Assert.assertFalse(conn.wasGet());
+        Assert.assertFalse(conn.wasDelete());
+        Assert.assertTrue(conn.wasPut());
+        Assert.assertFalse(conn.wasPost());
+    }
+
+    protected void verifyWasPost(StubRestConnection conn) {
+        Assert.assertFalse(conn.wasGet());
+        Assert.assertFalse(conn.wasDelete());
+        Assert.assertFalse(conn.wasPut());
+        Assert.assertTrue(conn.wasPost());
+    }
+
+    protected void verifyWasDelete(StubRestConnection conn) {
+        Assert.assertFalse(conn.wasGet());
+        Assert.assertTrue(conn.wasDelete());
+        Assert.assertFalse(conn.wasPut());
+        Assert.assertFalse(conn.wasPost());
+    }
+
+}

libs/sparkpost-lib/src/test/java/com/sparkpost/resources/ResourceMetricTests.java

@@ -17,7 +17,7 @@
 import com.sparkpost.model.responses.Response;
 import com.sparkpost.testhelpers.StubRestConnection;
 
-public class ResourceMetricTests {
+public class ResourceMetricTests extends BaseResourceTest {
 
     @BeforeClass
     public static void setUpClass() {
@@ -49,13 +49,6 @@ private StubRestConnection buildStubConnection() {
         return conn;
     }
 
-    private void verifyWasGet(StubRestConnection conn) {
-        Assert.assertTrue(conn.wasGet());
-        Assert.assertFalse(conn.wasDelete());
-        Assert.assertFalse(conn.wasPut());
-        Assert.assertFalse(conn.wasPost());
-    }
-
     @Test
     public void testGetDiscoverabilityLinks() throws SparkPostException {
         StubRestConnection conn = buildStubConnection();

libs/sparkpost-lib/src/test/java/com/sparkpost/resources/ResourceRecipientListsTests.java

@@ -0,0 +1,114 @@
+
+package com.sparkpost.resources;
+
+import java.lang.reflect.Type;
+
+import org.apache.log4j.Level;
+import org.apache.log4j.Logger;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import com.sparkpost.exception.SparkPostException;
+import com.sparkpost.model.RecipientList;
+import com.sparkpost.model.responses.RecipientListRetrieveResponse;
+import com.sparkpost.model.responses.RecipientListsListAllResponse;
+import com.sparkpost.model.responses.Response;
+import com.sparkpost.testhelpers.StubRestConnection;
+
+public class ResourceRecipientListsTests extends BaseResourceTest {
+
+    @BeforeClass
+    public static void setUpClass() {
+        Logger.getRootLogger().setLevel(Level.DEBUG);
+    }
+
+    @AfterClass
+    public static void tearDownClass() {
+    }
+
+    @Before
+    public void setUp() {
+    }
+
+    @After
+    public void tearDown() {
+    }
+
+    private static final class StubResponse extends Response {
+
+        public static Response decode(Response response, Type typeOfT) {
+            return new StubResponse();
+        }
+    }
+
+    private static final class StubRecipientListRetrieveResponse extends RecipientListRetrieveResponse {
+
+        public static RecipientListRetrieveResponse decode(Response response, Type typeOfT) {
+            return new StubRecipientListRetrieveResponse();
+        }
+    }
+
+    private static final class StubRecipientListsListAllResponse extends RecipientListsListAllResponse {
+
+        public static RecipientListsListAllResponse decode(Response response, Type typeOfT) {
+            return new StubRecipientListsListAllResponse();
+        }
+    }
+
+    private StubRestConnection buildStubConnection(Response response) {
+        StubRestConnection conn = new StubRestConnection(response);
+        return conn;
+    }
+
+    @Test
+    public void testCreate() throws SparkPostException {
+        Integer maxNumberOfRecipientErrors = 0;
+        RecipientList recipientList = new RecipientList();
+
+        StubRestConnection conn = buildStubConnection(new StubResponse());
+        Response response = ResourceRecipientLists.create(conn, maxNumberOfRecipientErrors, recipientList);
+        Assert.assertNotNull(response);
+
+        Assert.assertEquals(conn.getPath(), "/recipient-lists?num_rcpt_errors=0");
+        verifyWasPost(conn);
+    }
+
+    @Test
+    public void testRetrieve() throws SparkPostException {
+        String recipientListId = "recipientListId";
+
+        StubRestConnection conn = buildStubConnection(new StubRecipientListRetrieveResponse());
+        Response response = ResourceRecipientLists.retrieve(conn, recipientListId, Boolean.TRUE);
+        Assert.assertNotNull(response);
+
+        Assert.assertEquals(conn.getPath(), "/recipient-lists/recipientListId?show_recipients=true");
+        verifyWasGet(conn);
+    }
+
+    @Test
+    public void testListAll() throws SparkPostException {
+        StubRestConnection conn = buildStubConnection(new StubRecipientListsListAllResponse());
+        Response response = ResourceRecipientLists.listAll(conn);
+        Assert.assertNotNull(response);
+
+        Assert.assertEquals(conn.getPath(), "/recipient-lists");
+        verifyWasGet(conn);
+    }
+
+    @Test
+    public void testDelete() throws SparkPostException {
+        String recipientListId = "recipientListId";
+
+        StubRestConnection conn = buildStubConnection(new StubRecipientListsListAllResponse());
+        Response response = ResourceRecipientLists.delete(conn, recipientListId);
+        Assert.assertNotNull(response);
+
+        Assert.assertEquals(conn.getPath(), "/recipient-lists/recipientListId");
+        verifyWasDelete(conn);
+    }
+
+}