Update based on code review.

Author: yepher

apps/sparkpost-samples-app/src/main/java/com/sparkpost/error/samples/ForceTransportError.java

@@ -7,8 +7,8 @@
 import org.apache.log4j.Logger;
 
 import com.sparkpost.Client;
+import com.sparkpost.exception.SparkPostErrorServerResponseException;
 import com.sparkpost.exception.SparkPostException;
-import com.sparkpost.exception.SparkPostIllegalServerResponseException;
 import com.sparkpost.model.Webhook;
 import com.sparkpost.resources.ResourceWebhooks;
 import com.sparkpost.sdk.samples.helpers.SparkPostBaseApp;
@@ -46,9 +46,9 @@ private void foceFourHundredError() throws SparkPostException, IOException {
         webhook.setName("name with spaces");
         try {
             ResourceWebhooks.update(restConnection, webhook.getName(), webhook);
-            throw new IllegalStateException("Error: Expected SparkPostIllegalServerResponseException");
-        } catch (SparkPostIllegalServerResponseException e) {
-            System.out.println("GOOD: Sucecssfuly got a SparkPostIllegalServerResponseException");
+            throw new IllegalStateException("Error: Expected SparkPostErrorServerResponseException");
+        } catch (SparkPostErrorServerResponseException e) {
+            System.out.println("GOOD: Sucecssfuly got a SparkPostErrorServerResponseException");
 
         }
     }

libs/sparkpost-lib/src/main/java/com/sparkpost/exception/SparkPostErrorServerResponseException.java

@@ -1,6 +1,8 @@
+
 package com.sparkpost.exception;
 
 import com.yepher.jsondoc.annotations.Description;
+
 import lombok.Getter;
 
 public class SparkPostErrorServerResponseException extends SparkPostException {
@@ -15,4 +17,5 @@ public SparkPostErrorServerResponseException(String message, int responseCode) {
         super(message);
         this.responseCode = responseCode;
     }
+
 }

libs/sparkpost-lib/src/main/java/com/sparkpost/transport/RestConnection.java

@@ -315,17 +315,15 @@ private Response receiveErrorResponse(HttpURLConnection conn, Response response)
         response.setRequestId(conn.getHeaderField("X-SparkPost-Request-Id"));
 
         if (conn.getContentLength() == 0) {
-            throw new SparkPostIllegalServerResponseException(
+            throw new SparkPostErrorServerResponseException(
                     "Unexpected server response ContentType("
                             + conn.getContentType()
                             + ") from "
                             + conn.getURL()
-                            + " responseCode("
-                            + conn.getResponseCode()
-                            + ")"
                             + " contentLength("
                             + conn.getContentLength()
-                            + ")");
+                            + ")",
+                    conn.getResponseCode());
         }
         StringBuilder sb = new StringBuilder();