[endpoint] gracefully handle httpoison errors

Author: Ashu Goel

lib/endpoint.ex

@@ -86,6 +86,10 @@ defmodule SparkPost.Endpoint do
     end
   end
 
+  defp handle_response({:error, %HTTPoison.Error{reason: reason}}, _decode_results) do
+    %SparkPost.Endpoint.Error{status_code: nil, errors: [reason]}
+  end
+
   defp base_request_headers() do
     {:ok, version} = :application.get_key(:sparkpost, :vsn)
     %{

lib/mockserver.ex

@@ -36,4 +36,8 @@ defmodule SparkPost.MockServer do
   def mk_http_resp(status_code, body) do
     fn (_method, _url, _body, _headers, _opts) -> {:ok, %HTTPoison.Response{status_code: status_code, body: body}} end
   end
+
+  def mk_error(reason) do
+    fn (_method, _url, _body, _headers, _opts) -> {:error, %HTTPoison.Error{reason: reason}} end
+  end
 end

test/endpoint_test.exs

@@ -102,4 +102,14 @@ defmodule SparkPost.EndpointTest do
       Endpoint.request(:get, "transmissions", %{}, %{}, [])
     end
   end
+
+  test_with_mock "Endpoint request can handle httpoison timeouts", HTTPoison,
+  [request: fn (method, url, body, headers, opts) ->
+      fun = MockServer.mk_error(:timeout)
+      fun.(method, url, body, headers, opts)
+    end
+    ] do
+      assert %Endpoint.Error{errors: [:timeout], status_code: nil, results: nil} ==
+        Endpoint.request(:post, "transmissions", %{}, %{}, [])
+  end
 end