Skip to content

Commit fa24d26

Browse files
author
Stephen Powis
committed
Add warning log
1 parent f318b8d commit fa24d26

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/main/java/org/sourcelab/kafka/connect/apiclient/rest/HttpsContextBuilder.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import org.apache.http.conn.ssl.NoopHostnameVerifier;
2222
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
2323
import org.apache.http.ssl.SSLContexts;
24+
import org.slf4j.Logger;
25+
import org.slf4j.LoggerFactory;
2426
import org.sourcelab.kafka.connect.apiclient.Configuration;
2527

2628
import javax.net.ssl.HostnameVerifier;
@@ -42,6 +44,8 @@
4244
* Utility for properly configuring the SSL Context based on client configuration settings.
4345
*/
4446
class HttpsContextBuilder {
47+
private static final Logger logger = LoggerFactory.getLogger(HttpsContextBuilder.class);
48+
4549
/**
4650
* Accept TLS1.2, 1.1, and 1.0 protocols.
4751
*/
@@ -134,6 +138,11 @@ private String[] getSslProtocols() {
134138
* @return SslSocketFactory instance.
135139
*/
136140
LayeredConnectionSocketFactory createSslSocketFactory() {
141+
// Emit an warning letting everyone know we're using an insecure configuration.
142+
if (configuration.getIgnoreInvalidSslCertificates()) {
143+
logger.warn("Using insecure configuration, skipping server-side certificate validation checks.");
144+
}
145+
137146
return new SSLConnectionSocketFactory(
138147
getSslContext(),
139148
getSslProtocols(),

0 commit comments

Comments
 (0)