Code cleanup

Author: Crim

src/main/java/org/sourcelab/kafka/connect/apiclient/KafkaConnectClient.java

@@ -293,7 +293,7 @@ private <T> T submitRequest(final Request<T> request) {
         try {
             final RequestErrorResponse errorResponse = JacksonFactory.newInstance().readValue(responseStr, RequestErrorResponse.class);
             throw new InvalidRequestException(errorResponse.getMessage(), errorResponse.getErrorCode());
-        } catch (IOException e) {
+        } catch (final IOException e) {
             // swallow
         }
         throw new InvalidRequestException("Invalid response from server: " + responseStr, restResponse.getHttpCode());

src/main/java/org/sourcelab/kafka/connect/apiclient/rest/HttpClientRestClient.java

@@ -147,7 +147,7 @@ public void close() {
         if (httpClient != null) {
             try {
                 httpClient.close();
-            } catch (IOException e) {
+            } catch (final IOException e) {
                 logger.error("Error closing: {}", e.getMessage(), e);
             }
         }
@@ -178,7 +178,7 @@ public RestResponse submitRequest(final Request request) throws RestException {
                 default:
                     throw new IllegalArgumentException("Unknown Request Method: " + request.getRequestMethod());
             }
-        } catch (IOException exception) {
+        } catch (final IOException exception) {
             throw new RestException(exception.getMessage(), exception);
         }
     }
@@ -198,7 +198,7 @@ private <T> T submitGetRequest(final String url, final Map<String, String> getPa
                 .setCharset(StandardCharsets.UTF_8);
 
             // Attach submitRequest params
-            for (Map.Entry<String, String> entry : getParams.entrySet()) {
+            for (final Map.Entry<String, String> entry : getParams.entrySet()) {
                 uriBuilder.setParameter(entry.getKey(), entry.getValue());
             }
 
@@ -215,12 +215,12 @@ private <T> T submitGetRequest(final String url, final Map<String, String> getPa
 
             // Execute and return
             return httpClient.execute(get, responseHandler);
-        } catch (ClientProtocolException e) {
+        } catch (final ClientProtocolException e) {
             e.printStackTrace();
-        } catch (IOException e) {
+        } catch (final IOException e) {
             // Typically this is a parse error.
             e.printStackTrace();
-        } catch (URISyntaxException e) {
+        } catch (final URISyntaxException e) {
             // Bad URI building
             e.printStackTrace();
         }
@@ -257,9 +257,9 @@ private <T> T submitPostRequest(final String url, final Object requestBody, fina
 
             // Execute and return
             return httpClient.execute(post, responseHandler);
-        } catch (ClientProtocolException e) {
+        } catch (final ClientProtocolException e) {
             e.printStackTrace();
-        } catch (IOException e) {
+        } catch (final IOException e) {
             // Typically this is a parse error.
             e.printStackTrace();
         }
@@ -296,12 +296,12 @@ private <T> T submitPutRequest(final String url, final Object requestBody, final
 
             // Execute and return
             return httpClient.execute(put, responseHandler);
-        } catch (ClientProtocolException e) {
+        } catch (final ClientProtocolException e) {
             e.printStackTrace();
-        } catch (IOException e) {
+        } catch (final IOException e) {
             // Typically this is a parse error.
             e.printStackTrace();
-        } catch (URISyntaxException e) {
+        } catch (final URISyntaxException e) {
             // Bad URI building
             e.printStackTrace();
         }
@@ -340,12 +340,12 @@ private <T> T submitDeleteRequest(final String url, final Object requestBody, fi
 
             // Execute and return
             return httpClient.execute(delete, responseHandler);
-        } catch (ClientProtocolException e) {
+        } catch (final ClientProtocolException e) {
             e.printStackTrace();
-        } catch (IOException e) {
+        } catch (final IOException e) {
             // Typically this is a parse error.
             e.printStackTrace();
-        } catch (URISyntaxException e) {
+        } catch (final URISyntaxException e) {
             // Bad URI building
             e.printStackTrace();
         }

src/test/java/BadLoggersTest.java

@@ -48,12 +48,12 @@ public void doTest() throws FileNotFoundException {
         walk(projectRootPath);
     }
 
-    private void walk(File root) throws FileNotFoundException {
-        File[] list = root.listFiles();
+    private void walk(final File root) throws FileNotFoundException {
+        final File[] list = root.listFiles();
 
         if (list == null) return;
 
-        for (File f : list) {
+        for (final File f : list) {
             if (f.isDirectory()) {
                 walk(f);
             } else {
@@ -66,27 +66,27 @@ private void walk(File root) throws FileNotFoundException {
         }
     }
 
-    private void testFile(File myFile) throws FileNotFoundException {
-        String fileData = new Scanner(myFile).useDelimiter("\\Z").next();
+    private void testFile(final File myFile) throws FileNotFoundException {
+        final String fileData = new Scanner(myFile).useDelimiter("\\Z").next();
 
         // Look for our pattern
-        Matcher matches = regexPattern.matcher(fileData);
+        final Matcher matches = regexPattern.matcher(fileData);
 
         // If we didn't find a match
         if (!matches.find()) {
             return;
         }
 
         // Grab out the Class name
-        String loggerClassName = matches.group(1);
+        final String loggerClassName = matches.group(1);
         if (loggerClassName == null) {
             return;
         }
 
         // Get class name from the file name
         // I bet this will be completely broken for inner classes...
         // if you run into that, just exclude it? or figure out a better solution to this :p
-        String className = myFile.getName().replace(".java", "");
+        final String className = myFile.getName().replace(".java", "");
         if (!className.equals(loggerClassName)) {
             logger.info("Class {} ClassNameUsedByLogger {} ", className, loggerClassName);
             assertFalse("Found instance of logger using wrong class? " + myFile.getPath() + " Using " + loggerClassName, true);