Merge pull request #13 from SourceLabOrg/sp/updateDependencies

Update internal dependencies, resolve updated checkstyle rule violations

Author: Crim

build/checkstyle-v1.5.xml

@@ -37,9 +37,6 @@
             <property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
         </module>
         <module name="NeedBraces"/>
-        <module name="LeftCurly">
-            <property name="maxLineLength" value="100"/>
-        </module>
         <module name="RightCurly"/>
         <module name="RightCurly">
             <property name="option" value="alone"/>

pom.xml

@@ -47,10 +47,10 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
         <!-- guava version -->
-        <guava.version>25.0-jre</guava.version>
+        <guava.version>27.0.1-jre</guava.version>
 
         <!-- Http Components version -->
-        <http-components.version>4.5.5</http-components.version>
+        <http-components.version>4.5.7</http-components.version>
 
         <!-- Jackson version -->
         <jackson.version>2.9.8</jackson.version>
@@ -61,10 +61,10 @@
         <!-- Specify which Checkstyle ruleset to use -->
         <checkstyle.ruleset>build/checkstyle-v1.5.xml</checkstyle.ruleset>
         <checkstyle.plugin.version>2.17</checkstyle.plugin.version>
-        <checkstyle.version>8.0</checkstyle.version>
+        <checkstyle.version>8.17</checkstyle.version>
 
         <!-- Log4J Version -->
-        <log4j2.version>2.8.2</log4j2.version>
+        <log4j2.version>2.11.1</log4j2.version>
 
         <!-- test toggling -->
         <skipTests>false</skipTests>
@@ -141,7 +141,7 @@
         <dependency>
             <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-library</artifactId>
-            <version>1.3</version>
+            <version>2.1</version>
             <scope>test</scope>
         </dependency>
 

src/main/java/org/sourcelab/kafka/connect/apiclient/KafkaConnectClient.java

@@ -46,9 +46,9 @@
 import org.sourcelab.kafka.connect.apiclient.request.put.PutConnectorPluginConfigValidate;
 import org.sourcelab.kafka.connect.apiclient.request.put.PutConnectorResume;
 import org.sourcelab.kafka.connect.apiclient.rest.HttpClientRestClient;
-import org.sourcelab.kafka.connect.apiclient.rest.exceptions.InvalidRequestException;
 import org.sourcelab.kafka.connect.apiclient.rest.RestClient;
 import org.sourcelab.kafka.connect.apiclient.rest.RestResponse;
+import org.sourcelab.kafka.connect.apiclient.rest.exceptions.InvalidRequestException;
 
 import java.io.IOException;
 import java.util.Collection;

src/main/java/org/sourcelab/kafka/connect/apiclient/request/Request.java

@@ -26,17 +26,20 @@
 public interface Request<T> {
 
     /**
-     * @return The name of the end point this request uses. Example: "campaign", "user", etc..
+     * The name of the API end point to issue a request against.  This is appended to the API Hostname.
+     * @return The name of the end point this request uses.
      */
     String getApiEndpoint();
 
     /**
+     * Request Method, IE POST, GET, etc..
      * @return The type of HTTP Request.
      */
     RequestMethod getRequestMethod();
 
     /**
-     * @return correctly formatted request parameters.
+     * Object to be submitted as the body of the request.  It will be serialized to JSON using Jackson.
+     * @return Object representing request body content.
      */
     Object getRequestBody();
 

src/main/java/org/sourcelab/kafka/connect/apiclient/request/dto/ConnectorPluginConfigDefinition.java

@@ -29,7 +29,7 @@ public final class ConnectorPluginConfigDefinition {
     private final Map<String, String> config;
 
     /**
-     * Constructor
+     * Constructor.
      * @param connectorPluginName Name of Connector Plugin.
      * @param config Configuration values for connector.
      */

src/main/java/org/sourcelab/kafka/connect/apiclient/request/dto/NewConnectorDefinition.java

@@ -29,7 +29,7 @@ public final class NewConnectorDefinition {
     private final Map<String, String> config;
 
     /**
-     * Constructor
+     * Constructor.
      * @param name Name of Connector.
      * @param config Configuration values for connector.
      */

src/main/java/org/sourcelab/kafka/connect/apiclient/request/post/PostConnector.java

@@ -31,7 +31,7 @@ public final class PostConnector implements PostRequest<ConnectorDefinition> {
     private final NewConnectorDefinition connectorDefinition;
 
     /**
-     * Constructor
+     * Constructor.
      * @param connectorDefinition Defines the new connector to be deployed.
      */
     public PostConnector(final NewConnectorDefinition connectorDefinition) {

src/main/java/org/sourcelab/kafka/connect/apiclient/rest/exceptions/InvalidRequestException.java

@@ -48,7 +48,8 @@ public InvalidRequestException(final String message, final Throwable cause) {
     }
 
     /**
-     * @return Http Error Code.
+     * Resulting HTTP Status code.
+     * @return Http Status Code.
      */
     public int getErrorCode() {
         return errorCode;