Skip to content

Commit 7c9ad3e

Browse files
committed
fix datetime conversion
1 parent f0b204b commit 7c9ad3e

File tree

2 files changed

+22
-6
lines changed

2 files changed

+22
-6
lines changed

src/main/java/org/sourcelab/buildkite/api/client/request/ListBuildsRequest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,14 @@ public RequestParameters getRequestParameters() {
9191

9292
// Date Filters
9393
if (filters.getCreatedFrom() != null) {
94-
builder.withParameter("created_from", filters.getCreatedFrom().format(DateTimeFormatter.ISO_DATE));
94+
//2023-01-12T05:48:28Z
95+
builder.withParameter("created_from", filters.getCreatedFrom().format(DateTimeFormatter.ISO_OFFSET_DATE_TIME));
9596
}
9697
if (filters.getCreatedTo() != null) {
97-
builder.withParameter("created_to", filters.getCreatedTo().format(DateTimeFormatter.ISO_DATE));
98+
builder.withParameter("created_to", filters.getCreatedTo().format(DateTimeFormatter.ISO_OFFSET_DATE_TIME));
9899
}
99100
if (filters.getFinishedFrom() != null) {
100-
builder.withParameter("finished_from", filters.getFinishedFrom().format(DateTimeFormatter.ISO_DATE));
101+
builder.withParameter("finished_from", filters.getFinishedFrom().format(DateTimeFormatter.ISO_OFFSET_DATE_TIME));
101102
}
102103
return builder.build();
103104
}

src/test/java/org/sourcelab/buildkite/api/client/BuildkiteClientIntegrationTest.java

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import org.sourcelab.buildkite.api.client.response.Pipeline;
4242
import org.sourcelab.buildkite.api.client.util.BuildkiteClientUtils;
4343

44+
import java.time.ZonedDateTime;
4445
import java.util.List;
4546
import java.util.Optional;
4647

@@ -162,9 +163,9 @@ void getMeta() {
162163
@Test
163164
void listBuilds() {
164165
final BuildFilters filters = BuildFilters.newBuilder()
165-
.withPageOptions(1, 2)
166-
.withStateChooser().failed()
167-
.build();
166+
.withPageOptions(1, 2)
167+
.withStateChooser().failed()
168+
.build();
168169
final ListBuildsResponse result = client.listBuilds(filters);
169170
logger.info("Result: {}", result);
170171

@@ -180,6 +181,20 @@ void listBuilds() {
180181
assertNotNull(resultPage2, "Page 2 result should be not null.");
181182
}
182183

184+
/**
185+
* Sanity test the 'listBuilds' request.
186+
*/
187+
@Test
188+
void listBuilds_withDateTimeCriteria() {
189+
final BuildFilters filters = BuildFilters.newBuilder()
190+
.withPageOptions(1, 2)
191+
.withCreatedFrom(ZonedDateTime.now().minusDays(1))
192+
.withStateChooser().failed()
193+
.build();
194+
final ListBuildsResponse result = client.listBuilds(filters);
195+
logger.info("Result: {}", result);
196+
}
197+
183198
/**
184199
* Sanity test BuildkiteClientUtils.retrieveAll().
185200
*/

0 commit comments

Comments
 (0)