Fixed logger not closing file handlers properly when unloading plugins. (#408)

Author: CookStar

addons/source-python/packages/source-python/loggers.py

@@ -102,12 +102,16 @@ def __getattr__(self, attr):
         return self[attr]
 
     def __delitem__(self, item):
-        """Remove all children of the instance and closes the logger."""
+        """Remove all children of the instance and
+        remove the logger from logging manager.
+        """
+        instance = self.pop(item)
+
         # Remove all children
-        self[item].clear()
+        instance.clear()
 
-        # Close the logger
-        self.logger.close()
+        # Remove the logger from logging manager
+        self.logger.manager.loggerDict.pop(instance.logger.name, None)
 
     def clear(self):
         """Delete each item individually to close all loggers."""
@@ -391,9 +395,15 @@ def areas(self):
         return self._areas.get_int()
 
     def _unload_instance(self):
-        """Remove the logger from logging manager."""
+        """Remove the logger from logging manager and close it."""
+        self.clear()
         self.logger.manager.loggerDict.pop(self.logger.name, None)
 
+        for handler in self.logger.handlers[:]:
+            self.logger.removeHandler(handler)
+            handler.close()
+
+
 # Set the core ConVars
 _level = ConVar(
     'sp_logging_level', '0', 'The Source.Python base logging level')