Login tests (#33)

* added custom webId profile with no oidcissuer for testing purposes

* added second pod with bad webId profile for testing purposes

* updated pods prepare script

* created script to configure the pods with our custom files

* added test for user trying to log in with webid without oidcissuer

* created webId document with invalid rdf

* added pod with invalid rdf document

* setting the webid document of invalidWebId pod to an invalid document

* added test for a user trying to log in with a webid that has an invalid webid document

* added test for user trying to log in with invalid idp url

* changed cypress open to run

* Clean up

* Remove commented lines in script

* Typo

* Add Markdown linter

---------

Co-authored-by: Pieter Heyvaert <pheyvaer.heyvaert@ugent.be>

Author: AronBuzogany

.gitignore

@@ -26,5 +26,4 @@ dist-ssr
 pods*
 
 lintPush.sh
-
 cypress/screenshots

.markdownlint-cli2.cjs

@@ -0,0 +1,38 @@
+"use strict";
+
+module.exports = {
+  ignores: [ "node_modules/", "LICENSE.md", ".github/" ],
+
+  globs: [ "**/*.md" ],
+
+  config: {
+    // Enable all markdownlint rules
+    default: true,
+
+    MD004: {
+      "style": "dash"
+    },
+
+    // Set list indent level to 2
+    MD007: { "indent": 2 },
+
+    // Enable line length check but exclude tables and code blocks
+    MD013: {
+      line_length: 120,
+      tables: false,
+      code_blocks: false
+    },
+
+    // Allow multiple subheadings with the same content
+    // across different section (#1 ##A ##B #2 ##A ##B)
+    MD024: {
+      allow_different_nesting: true
+    },
+
+    // Set Ordered list item prefix to "ordered" (use 1. 2. 3. not 1. 1. 1.)
+    MD029: { "style": "ordered" },
+
+    // Allow inline HTML
+    MD033: false,
+  }
+};

README.md

@@ -90,7 +90,8 @@ The underscore `_` here is crucial to make a clear distinction between name and
 ### Representation Mapper
 
 If you want to add your own type representations
-you can do this by adding your representation to the [typeMapper.js](./src/representationProvider/representationProvider.jsx) file.
+you can do this by adding your representation to the
+[typeMapper.js](./src/representationProvider/representationProvider.jsx) file.
 This can be useful for example when querying images.
 The result of the query is a reference to the image.
 By mapping a representation we can show the actual image instead of the reference.
@@ -115,7 +116,8 @@ The components get the following props:
 - `record` (the query result), an object of `RDF/JS` objects.
 - `variable` the variable name and key of `record`, a string.
 
-`Hint` use the [Field components](https://marmelab.com/react-admin/doc/3.19/Fields.html#basic-fields) from `react-admin` to display the result.
+`Hint` use the [Field components](https://marmelab.com/react-admin/doc/3.19/Fields.html#basic-fields)
+from `react-admin` to display the result.
 They've already got styling matching that of `react-admin` and are easy to use.
 
 `Warning` if you change the record object, the changed will still be present in the next render.
@@ -157,14 +159,18 @@ For testing we use [Cypress](https://www.cypress.io/).
    Keep the server running.
 
 2. Start the Web application
+
    ```bash
    npm run dev
    ```
+
    Also keep this process running.
 3. Start the http proxy
+
    ```bash
    npm run start:proxy
    ```
+
 4. Start a server which denies all cors header
 
    ```bash
@@ -174,6 +180,7 @@ For testing we use [Cypress](https://www.cypress.io/).
    This process must also be active throughout the tests.
 
 5. Finally, you can execute the tests by running
+
    ```bash
    npm run test
    ```

cypress/e2e/spec.cy.js

@@ -1,5 +1,5 @@
 describe("Web app", () => {
-  it("Successfully loads.", () => {
+  it("Successfully loads", () => {
     cy.visit("/");
   });
 
@@ -85,35 +85,56 @@ describe("Web app", () => {
     cy.contains("Ludwig van Beethoven");
   });
 
-  it("Log in and execute query on private data", () => {
+  it("Log in with WebID with no OIDC issuer", () => {
     cy.visit("/");
 
     cy.get('[aria-label="Profile"]').click();
     cy.contains('[role="menuitem"]', "Login").click();
 
-    cy.get('input[name="idp"]').clear();
-    cy.get('input[name="idp"]').type("http://localhost:8080");
+    cy.get('input[value="webId"]').click();
+
+    cy.get('input[name="idp"]')
+      .clear();
+    cy.get('input[name="idp"]')
+      .type("http://localhost:8080/example2/profile/card#me");
     cy.contains("Login").click();
 
-    cy.get("input#email").type("hello@example.com");
-    cy.get("input#password").type("abc123");
-    cy.contains("button", "Log in").click();
-    cy.contains("button", "Authorize").click();
+    cy.contains("No IDP found");
+  });
 
-    cy.url().should("eq", "http://localhost:5173/");
+  it("Log in with invalid WebID document", () => {
+    cy.visit("/");
 
-    cy.contains("A list of my favorite books").click();
-    cy.contains("It Ends With Us");
+    cy.get('[aria-label="Profile"]').click();
+    cy.contains('[role="menuitem"]', "Login").click();
+
+    cy.get('input[value="webId"]').click();
+
+    cy.get('input[name="idp"]')
+      .clear();
+    cy.get('input[name="idp"]')
+      .type("http://localhost:8080/invalidWebId/profile/card#me");
+    cy.contains("Login").click();
+
+    cy.contains("Couldn't query the Identity Provider from the WebID");
   });
 
-  it("Query on private data unauthenticated", () => {
+  it("Log in with an invalid IDP issuer", () => {
     cy.visit("/");
 
-    cy.contains("A list of my favorite books").click();
-    cy.get("div").should("have.class", "MuiSnackbarContent-message");
+    cy.get('[aria-label="Profile"]').click();
+    cy.contains('[role="menuitem"]', "Login").click();
+
+    cy.get('input[name="idp"]')
+      .clear();
+    cy.get('input[name="idp"]')
+      .type("https://facebook.com");
+    cy.contains("Login").click();
+
+    cy.contains("Login failed");
   });
 
-  it('Querying resource with "bad" cors header, though a proxy should work', () => {
+  it("Log in and execute query on private data", () => {
     cy.visit("/");
 
     cy.get('[aria-label="Profile"]').click();
@@ -130,6 +151,20 @@ describe("Web app", () => {
 
     cy.url().should("eq", "http://localhost:5173/");
 
+    cy.contains("A list of my favorite books").click();
+    cy.contains("It Ends With Us");
+  });
+
+  it("Query on private data unauthenticated", () => {
+    cy.visit("/");
+
+    cy.contains("A list of my favorite books").click();
+    cy.get("div").should("have.class", "MuiSnackbarContent-message");
+  });
+
+  it('Querying resource with "bad" cors header, though a proxy should work', () => {
+    cy.visit("/");
+
     cy.contains("My idols").click();
     cy.get(".MuiSnackbarContent-message").should("not.exist");
   });