Skip to content

Commit fc7fb60

Browse files
committed
fix(workflows): restore full context in Python version comments
Restored the detailed explanation about Python 3.13's hashlib.md5() incompatibility with gyp. The full context is important for understanding why we use 3.11 and what breaks in 3.13.
1 parent f531130 commit fc7fb60

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

.github/workflows/build-sea.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,7 @@ jobs:
338338
# Use 3.11 to match Alpine 3.19 (Docker builds) which ships Python 3.11.14.
339339
# Python 3.13 breaks gyp with: TypeError: Strings must be encoded before hashing
340340
# At: tools/gyp/pylib/gyp/generator/ninja.py:813 hashlib.md5(outputs[0])
341+
# Python 3.13 requires .encode() for hashlib, but gyp doesn't support it yet.
341342
# Using 3.11 ensures consistency across standard and Alpine builds.
342343
python-version: '3.11'
343344

.github/workflows/build-smol.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ jobs:
348348
# Use 3.11 to match Alpine 3.19 (Docker builds) which ships Python 3.11.14.
349349
# Python 3.13 breaks gyp with: TypeError: Strings must be encoded before hashing
350350
# At: tools/gyp/pylib/gyp/generator/ninja.py:813 hashlib.md5(outputs[0])
351+
# Python 3.13 requires .encode() for hashlib, but gyp doesn't support it yet.
351352
# Using 3.11 ensures consistency across standard and Alpine builds.
352353
python-version: '3.11'
353354

.github/workflows/build-wasm.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ jobs:
207207
# Use 3.11 to match Alpine 3.19 (Docker builds) which ships Python 3.11.14.
208208
# Python 3.13 breaks gyp with: TypeError: Strings must be encoded before hashing
209209
# At: tools/gyp/pylib/gyp/generator/ninja.py:813 hashlib.md5(outputs[0])
210+
# Python 3.13 requires .encode() for hashlib, but gyp doesn't support it yet.
210211
# Using 3.11 ensures consistency across standard and Alpine builds.
211212
python-version: '3.11'
212213

0 commit comments

Comments
 (0)