Commit fbc244a
committed
fix(smol): use GYP_MSVS_OVERRIDE_PATH to bypass registry detection
Gyp's SelectVisualStudioVersion queries Windows registry even when
version is specified. Setting GYP_MSVS_OVERRIDE_PATH bypasses registry
detection and directly uses the VS path from vswhere.
Changes:
- Workflow: Export GYP_MSVS_VERSION=2022 and GYP_MSVS_OVERRIDE_PATH
- build.mjs: Remove -G flag, rely on env vars, add gyp vars to debug log
https://github.com/nodejs/node/blob/main/tools/gyp/pylib/gyp/MSVSVersion.py1 parent 135facb commit fbc244a
File tree
2 files changed
+33
-9
lines changed- .github/workflows
- packages/node-smol-builder/scripts
2 files changed
+33
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
660 | 660 | | |
661 | 661 | | |
662 | 662 | | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
663 | 682 | | |
664 | 683 | | |
665 | 684 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1424 | 1424 | | |
1425 | 1425 | | |
1426 | 1426 | | |
1427 | | - | |
1428 | | - | |
1429 | | - | |
1430 | | - | |
1431 | | - | |
1432 | | - | |
1433 | | - | |
1434 | 1427 | | |
1435 | 1428 | | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
1436 | 1433 | | |
1437 | 1434 | | |
1438 | 1435 | | |
1439 | 1436 | | |
1440 | 1437 | | |
1441 | 1438 | | |
1442 | 1439 | | |
1443 | | - | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
1444 | 1448 | | |
1445 | 1449 | | |
1446 | 1450 | | |
1447 | | - | |
| 1451 | + | |
| 1452 | + | |
1448 | 1453 | | |
1449 | 1454 | | |
1450 | 1455 | | |
| |||
0 commit comments