Rename some KeySubspace.FromKey(..) into CreateDynamic(..) or CreateTyped(..)

Author: KrzysFR

FoundationDB.Client/Layers/Directories/FdbDirectoryLayer.cs

@@ -160,7 +160,7 @@ internal FdbDirectoryLayer(IDynamicKeySubspace nodeSubspace, IDynamicKeySubspace
 		[NotNull]
 		public static FdbDirectoryLayer Create(Slice prefix, IEnumerable<string> path = null, IKeyEncoding encoding = null)
 		{
-			var subspace = KeySubspace.FromKey(prefix, encoding ?? TypeSystem.Tuples);
+			var subspace = KeySubspace.CreateDynamic(prefix, encoding ?? TypeSystem.Tuples);
 			var location = path != null ? ParsePath(path) : STuple.Empty;
 			return new FdbDirectoryLayer(subspace.Partition[FdbKey.Directory], subspace, location);
 		}

FoundationDB.Client/Subspaces/KeySubspace.cs

@@ -65,7 +65,7 @@ public static KeySubspace FromKey(Slice prefix)
 		/// <summary>Initializes a new dynamic subspace with the given binary <paramref name="prefix"/> and key <paramref name="encoder"/>.</summary>
 		/// <returns>A subspace that can handle keys of any types and size.</returns>
 		[Pure, NotNull]
-		public static DynamicKeySubspace FromKey(Slice prefix, [NotNull] IDynamicKeyEncoder encoder)
+		public static DynamicKeySubspace CreateDynamic(Slice prefix, [NotNull] IDynamicKeyEncoder encoder)
 		{
 			Contract.NotNull(encoder, nameof(encoder));
 			return new DynamicKeySubspace(prefix, encoder);
@@ -74,67 +74,67 @@ public static DynamicKeySubspace FromKey(Slice prefix, [NotNull] IDynamicKeyEnco
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a dynamic key <paramref name="encoding"/>.</summary>
 		/// <returns>A subspace that can handle keys of any types and size.</returns>
 		[Pure, NotNull]
-		public static DynamicKeySubspace FromKey(Slice prefix, [NotNull] IKeyEncoding encoding)
+		public static DynamicKeySubspace CreateDynamic(Slice prefix, [NotNull] IKeyEncoding encoding)
 		{
 			Contract.NotNull(encoding, nameof(encoding));
 			return new DynamicKeySubspace(prefix, encoding.GetDynamicEncoder());
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoding"/>.</summary>
 		/// <returns>A subspace that can handle keys of type <typeparamref name="T1"/>.</returns>
-		public static TypedKeySubspace<T1> FromKey<T1>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
+		public static TypedKeySubspace<T1> CreateTyped<T1>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
 		{
 			return new TypedKeySubspace<T1>(prefix, (encoding ?? TypeSystem.Tuples).GetEncoder<T1>());
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoder"/>.</summary>
 		/// <returns>A subspace that can handle keys of type <typeparamref name="T1"/>.</returns>
-		public static TypedKeySubspace<T1> FromKey<T1>(Slice prefix, [NotNull] IKeyEncoder<T1> encoder)
+		public static TypedKeySubspace<T1> CreateTyped<T1>(Slice prefix, [NotNull] IKeyEncoder<T1> encoder)
 		{
 			Contract.NotNull(encoder, nameof(encoder));
 			return new TypedKeySubspace<T1>(prefix, encoder);
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoding"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>).</returns>
-		public static TypedKeySubspace<T1, T2> FromKey<T1, T2>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
+		public static TypedKeySubspace<T1, T2> CreateTyped<T1, T2>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
 		{
 			return new TypedKeySubspace<T1, T2>(prefix, (encoding ?? TypeSystem.Tuples).GetEncoder<T1, T2>());
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoder"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>).</returns>
-		public static TypedKeySubspace<T1, T2> FromKey<T1, T2>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2> encoder)
+		public static TypedKeySubspace<T1, T2> CreateTyped<T1, T2>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2> encoder)
 		{
 			Contract.NotNull(encoder, nameof(encoder));
 			return new TypedKeySubspace<T1, T2>(prefix, encoder);
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoding"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>, <typeparamref name="T3"/>).</returns>
-		public static TypedKeySubspace<T1, T2, T3> FromKey<T1, T2, T3>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
+		public static TypedKeySubspace<T1, T2, T3> CreateTyped<T1, T2, T3>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
 		{
 			return new TypedKeySubspace<T1, T2, T3>(prefix, (encoding ?? TypeSystem.Tuples).GetEncoder<T1, T2, T3>());
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoder"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>, <typeparamref name="T3"/>).</returns>
-		public static TypedKeySubspace<T1, T2, T3> FromKey<T1, T2, T3>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2, T3> encoder)
+		public static TypedKeySubspace<T1, T2, T3> CreateTyped<T1, T2, T3>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2, T3> encoder)
 		{
 			Contract.NotNull(encoder, nameof(encoder));
 			return new TypedKeySubspace<T1, T2, T3>(prefix, encoder);
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoding"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>, <typeparamref name="T3"/>).</returns>
-		public static TypedKeySubspace<T1, T2, T3, T4> FromKey<T1, T2, T3, T4>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
+		public static TypedKeySubspace<T1, T2, T3, T4> CreateTyped<T1, T2, T3, T4>(Slice prefix, [CanBeNull] IKeyEncoding encoding = null)
 		{
 			return new TypedKeySubspace<T1, T2, T3, T4>(prefix, (encoding ?? TypeSystem.Tuples).GetEncoder<T1, T2, T3, T4>());
 		}
 
 		/// <summary>Initializes a new subspace with the given binary <paramref name="prefix"/>, that uses a typed key <paramref name="encoder"/>.</summary>
 		/// <returns>A subspace that can handle composite keys of type (<typeparamref name="T1"/>, <typeparamref name="T2"/>, <typeparamref name="T3"/>).</returns>
-		public static TypedKeySubspace<T1, T2, T3, T4> FromKey<T1, T2, T3, T4>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2, T3, T4> encoder)
+		public static TypedKeySubspace<T1, T2, T3, T4> CreateTyped<T1, T2, T3, T4>(Slice prefix, [NotNull] ICompositeKeyEncoder<T1, T2, T3, T4> encoder)
 		{
 			Contract.NotNull(encoder, nameof(encoder));
 			return new TypedKeySubspace<T1, T2, T3, T4>(prefix, encoder);

FoundationDB.Tests/SubspaceFacts.cs

@@ -52,7 +52,7 @@ public void Test_Empty_Subspace_Is_Empty()
 		[Category("LocalCluster")]
 		public void Test_Subspace_With_Binary_Prefix()
 		{
-			var subspace = KeySubspace.FromKey(new byte[] { 42, 255, 0, 127 }.AsSlice(), TypeSystem.Tuples);
+			var subspace = KeySubspace.CreateDynamic(new byte[] { 42, 255, 0, 127 }.AsSlice(), TypeSystem.Tuples);
 
 			Assert.That(subspace.GetPrefix().ToString(), Is.EqualTo("*<FF><00><7F>"));
 			Assert.That(KeySubspace.Copy(subspace), Is.Not.SameAs(subspace));
@@ -117,7 +117,7 @@ public void Test_Cannot_Create_Or_Partition_Subspace_With_Slice_Nil()
 		[Category("LocalCluster")]
 		public void Test_Subspace_With_Tuple_Prefix()
 		{
-			var subspace = KeySubspace.FromKey(TuPack.EncodeKey("hello"), TypeSystem.Tuples);
+			var subspace = KeySubspace.CreateDynamic(TuPack.EncodeKey("hello"), TypeSystem.Tuples);
 
 			Assert.That(subspace.GetPrefix().ToString(), Is.EqualTo("<02>hello<00>"));
 			Assert.That(KeySubspace.Copy(subspace), Is.Not.SameAs(subspace));
@@ -149,7 +149,7 @@ public void Test_Subspace_With_Tuple_Prefix()
 		public void Test_Subspace_Partitioning_With_Binary_Suffix()
 		{
 			// start from a parent subspace
-			var parent = KeySubspace.FromKey(Slice.Empty, TypeSystem.Tuples);
+			var parent = KeySubspace.CreateDynamic(Slice.Empty, TypeSystem.Tuples);
 			Assert.That(parent.GetPrefix().ToString(), Is.EqualTo("<empty>"));
 
 			// create a child subspace using a tuple
@@ -176,7 +176,7 @@ public void Test_Subspace_Partitioning_With_Binary_Suffix()
 		[Test]
 		public void Test_DynamicKeySpace_API()
 		{
-			var location = KeySubspace.FromKey(Slice.FromString("PREFIX"), TypeSystem.Tuples);
+			var location = KeySubspace.CreateDynamic(Slice.FromString("PREFIX"), TypeSystem.Tuples);
 
 			Assert.That(location[Slice.FromString("SUFFIX")].ToString(), Is.EqualTo("PREFIXSUFFIX"));
 
@@ -229,7 +229,7 @@ public void Test_DynamicKeySpace_API()
 		[Test]
 		public void Test_TypedKeySpace_T1()
 		{
-			var location = KeySubspace.FromKey<string>(Slice.FromString("PREFIX"));
+			var location = KeySubspace.CreateTyped<string>(Slice.FromString("PREFIX"));
 			Assert.That(location.KeyEncoder, Is.Not.Null, "Should have a Key Encoder");
 			Assert.That(location.KeyEncoder.Encoding, Is.SameAs(TypeSystem.Tuples), "Encoder should use Tuple type system");