Remove usage of Slice.DefaultEncoding

Author: KrzysFR

FoundationDB.Client/Native/FdbNative.cs

@@ -36,6 +36,7 @@ namespace FoundationDB.Client.Native
 	using System.IO;
 	using System.Runtime.ExceptionServices;
 	using System.Runtime.InteropServices;
+	using System.Text;
 	using Doxense.Diagnostics.Contracts;
 
 	internal static unsafe class FdbNative
@@ -303,11 +304,11 @@ public static Slice ToNativeString(string value, bool nullTerminated)
 			if (nullTerminated)
 			{ // NULL terminated ANSI string
 				result = new byte[value.Length + 1];
-				Slice.DefaultEncoding.GetBytes(value, 0, value.Length, result, 0);
+				Encoding.Default.GetBytes(value, 0, value.Length, result, 0);
 			}
 			else
 			{
-				result = Slice.DefaultEncoding.GetBytes(value);
+				result = Encoding.Default.GetBytes(value);
 			}
 			return Slice.CreateUnsafe(result, 0, result.Length);
 		}

FoundationDB.Client/Shared/Memory/Slice.Encoding.cs

@@ -594,14 +594,6 @@ public static Slice FromUuid64(Uuid64 value)
 			return value.ToSlice();
 		}
 
-		/// <summary>Encoding used to produce ASCII slices</summary>
-		[NotNull]
-		internal static readonly ASCIIEncoding AsciiEncoding = new ASCIIEncoding();
-
-		/// <summary>Encoding used to produce ANSI slices</summary>
-		[NotNull]
-		internal static readonly Encoding DefaultEncoding = Encoding.Default;
-
 		/// <summary>Encoding used to produce UTF-8 slices</summary>
 		[NotNull]
 		internal static readonly UTF8Encoding Utf8NoBomEncoding = new UTF8Encoding(encoderShouldEmitUTF8Identifier: false, throwOnInvalidBytes: true);
@@ -616,7 +608,7 @@ public static Slice FromStringAnsi([CanBeNull] string text)
 		{
 			return text == null ? Slice.Nil
 				 : text.Length == 0 ? Slice.Empty
-				 : new Slice(DefaultEncoding.GetBytes(text));
+				 : new Slice(Encoding.Default.GetBytes(text));
 		}
 
 		/// <summary>Create a slice from an ASCII string, where all the characters map directory into bytes (0..255). The string will be checked before being encoded.</summary>
@@ -1426,7 +1418,7 @@ public string ToStringAnsi()
 		{
 			if (this.Count == 0) return this.Array != null ? String.Empty : default(string);
 			//note: Encoding.GetString() will do the bound checking for us
-			return Slice.DefaultEncoding.GetString(this.Array, this.Offset, this.Count);
+			return Encoding.Default.GetString(this.Array, this.Offset, this.Count);
 		}
 
 		/// <summary>Stringify a slice containing 7-bit ASCII characters only</summary>