Do not use direct Slice constructor

Author: KrzysFR

FoundationDB.Client/FdbKey.cs

@@ -83,7 +83,7 @@ public static Slice Increment(Slice slice)
 				throw Fdb.Errors.CannotIncrementKey();
 			}
 
-			return new Slice(tmp, 0, lastNonFFByte + 1);
+			return tmp.AsSlice(0, lastNonFFByte + 1);
 		}
 
 		/// <summary>Merge an array of keys with a same prefix, all sharing the same buffer</summary>
@@ -162,7 +162,7 @@ internal static Slice[] SplitIntoSegments([NotNull] byte[] buffer, int start, [N
 			int p = start;
 			foreach (var end in endOffsets)
 			{
-				result[i++] = new Slice(buffer, p, end - p);
+				result[i++] = buffer.AsSlice(p, end - p);
 				p = end;
 			}
 

FoundationDB.Client/Filters/Logging/FdbLoggedTransaction.cs

@@ -114,7 +114,7 @@ private Slice Grab(Slice slice)
 				int start = m_offset;
 				slice.CopyTo(m_buffer, m_offset);
 				m_offset += slice.Count;
-				return new Slice(m_buffer, start, slice.Count);
+				return m_buffer.AsSlice(start, slice.Count);
 			}
 		}
 

FoundationDB.Client/Native/FdbNative.cs

@@ -309,7 +309,7 @@ public static Slice ToNativeString(string value, bool nullTerminated)
 			{
 				result = Slice.DefaultEncoding.GetBytes(value);
 			}
-			return new Slice(result, 0, result.Length);
+			return Slice.CreateUnsafe(result, 0, result.Length);
 		}
 
 
@@ -696,7 +696,7 @@ public static FdbError FutureGetValue(FutureHandle future, out bool valuePresent
 			{
 				var bytes = new byte[valueLength];
 				Marshal.Copy(new IntPtr(ptr), bytes, 0, valueLength);
-				value = new Slice(bytes, 0, valueLength);
+				value = Slice.CreateUnsafe(bytes, 0, valueLength);
 			}
 			else
 			{
@@ -785,8 +785,8 @@ public static FdbError FutureGetKeyValueArray(FutureHandle future, out KeyValueP
 						Marshal.Copy(kvp[i].Value, page, p + kl, vl);
 
 						result[i] = new KeyValuePair<Slice, Slice>(
-							new Slice(page, p, kl),
-							new Slice(page, p + kl, vl)
+							page.AsSlice(p, kl),
+							page.AsSlice(p + kl, vl)
 						);
 
 						p += kl + vl;

FoundationDB.Client/Tuples/Encoding/TupleParser.cs

@@ -883,9 +883,7 @@ public static Slice ParseBytes(Slice slice)
 			Contract.Requires(slice.HasValue && slice[0] == TupleTypes.Bytes && slice[-1] == 0);
 			if (slice.Count <= 2) return Slice.Empty;
 
-			var decoded = UnescapeByteString(slice.Array, slice.Offset + 1, slice.Count - 2);
-
-			return new Slice(decoded.Array, decoded.Offset, decoded.Count);
+			return UnescapeByteString(slice.Array, slice.Offset + 1, slice.Count - 2);
 		}
 
 		/// <summary>Parse a tuple segment containing an ASCII string stored as a byte array</summary>

FoundationDB.Layers.Common/Blobs/FdbBlob.cs

@@ -274,7 +274,7 @@ await trans
 				})
 				.ConfigureAwait(false);
 
-			return new Slice(buffer, 0, buffer.Length);
+			return buffer.AsSlice(0, buffer.Length);
 		}
 
 		/// <summary>