Merge pull request #20 from erodewald/10-uninstall-handler-broken

Fix uninstalled() assigning to wrong handler

Author: erodewald

lib/smart-app.js

@@ -161,7 +161,7 @@ module.exports = class SmartApp {
 	/// ////////////
 
 	uninstalled(callback) {
-		this._installedHandler = callback
+		this._uninstalledHandler = callback
 		return this
 	}
 

test/smartapp-page-spec.js

@@ -1,4 +1,5 @@
 /* eslint no-undef: "off" */
+const assert = require('assert').strict
 const SmartApp = require('../lib/smart-app')
 
 describe('smartapp-page-spec', () => {
@@ -39,7 +40,7 @@ describe('smartapp-page-spec', () => {
 			settings: {}
 		})
 
-		const pageReponse = app.handleMockCallback({
+		const pageResponse = app.handleMockCallback({
 			lifecycle: 'CONFIGURATION',
 			executionId: 'abcf6e72-60f4-1f27-341b-449ad9e2192e',
 			locale: 'en',
@@ -59,8 +60,66 @@ describe('smartapp-page-spec', () => {
 			settings: {}
 		})
 
-		console.log(JSON.stringify(initResponse, null, 2))
-		console.log(JSON.stringify(pageReponse, null, 2))
+		const expectedInitResponse = {initialize: {
+			id: 'xxx',
+			firstPageId: 'eaMainPage',
+			permissions: [],
+			disableCustomDisplayName: false,
+			disableRemoveApp: false
+		}}
+
+		const expectedPageResponse = {
+			page: {
+				name: 'pages.eaMainPage.name',
+				complete: true,
+				pageId: 'eaMainPage',
+				nextPageId: null,
+				previousPageId: null,
+				sections: [
+					{
+						name: 'whenDoorOpensAndCloses',
+						settings: [
+							{
+								id: 'contactSensor',
+								name: 'pages.eaMainPage.settings.contactSensor.name',
+								required: true,
+								type: 'DEVICE',
+								description: 'Tap to set',
+								multiple: false,
+								capabilities: [
+									'contactSensor'
+								],
+								permissions: [
+									'r'
+								]
+							}
+						]
+					},
+					{
+						name: 'turnLightsOnAndOff',
+						settings: [
+							{
+								id: 'lights',
+								name: 'pages.eaMainPage.settings.lights.name',
+								required: true,
+								type: 'DEVICE',
+								description: 'Tap to set',
+								multiple: true,
+								capabilities: [
+									'switch'
+								],
+								permissions: [
+									'r',
+									'x'
+								]
+							}
+						]
+					}
+				]
+			}
+		}
+		assert.deepStrictEqual(initResponse.configurationData, expectedInitResponse)
+		assert.deepStrictEqual(pageResponse.configurationData, expectedPageResponse)
 	})
 
 	it('should configure event logger', () => {

test/smartapp-spec.js

@@ -0,0 +1,82 @@
+/* eslint no-undef: "off" */
+const assert = require('assert').strict
+const SmartApp = require('../lib/smart-app')
+
+describe('smartapp-spec', () => {
+	let app
+	let expectedData
+	let receivedData
+
+	beforeEach(() => {
+		app = new SmartApp()
+		expectedData = {
+			authToken: 'string',
+			refreshToken: 'string',
+			installedApp: {
+				installedAppId: 'd692699d-e7a6-400d-a0b7-d5be96e7a564',
+				locationId: 'e675a3d9-2499-406c-86dc-8a492a886494',
+				config: {}
+			}
+		}
+	})
+
+	it('should handle INSTALL event', () => {
+		app.installed((_, installData) => {
+			receivedData = installData
+		})
+		app.handleMockCallback({
+			lifecycle: 'INSTALL',
+			executionId: 'e6903fe6-f88f-da69-4c12-e2802606ccbc',
+			locale: 'en',
+			version: '0.1.0',
+			client: {
+				os: 'ios',
+				version: '0.0.0',
+				language: 'en-US'
+			},
+			installData: expectedData,
+			settings: {}
+		})
+		assert.strictEqual(receivedData, expectedData)
+	})
+
+	it('should handle UNINSTALL event', () => {
+		app.uninstalled((_, uninstallData) => {
+			receivedData = uninstallData
+		})
+		app.handleMockCallback({
+			lifecycle: 'UNINSTALL',
+			executionId: 'e6903fe6-f88f-da69-4c12-e2802606ccbc',
+			locale: 'en',
+			version: '0.1.0',
+			client: {
+				os: 'ios',
+				version: '0.0.0',
+				language: 'en-US'
+			},
+			uninstallData: expectedData,
+			settings: {}
+		})
+		assert.strictEqual(receivedData, expectedData)
+	})
+
+	it('should handle UPDATE event', () => {
+		app.updated((_, updateData) => {
+			receivedData = updateData
+		})
+		app.handleMockCallback({
+			lifecycle: 'UPDATE',
+			executionId: 'e6903fe6-f88f-da69-4c12-e2802606ccbc',
+			locale: 'en',
+			version: '0.1.0',
+			client: {
+				os: 'ios',
+				version: '0.0.0',
+				language: 'en-US'
+			},
+			updateData: expectedData,
+			settings: {}
+		})
+		assert.strictEqual(receivedData, expectedData)
+	})
+})