Skip to content

Commit d4c7280

Browse files
Apply changes regarding to review (2)
1 parent d4a4e71 commit d4c7280

File tree

4 files changed

+14
-20
lines changed

4 files changed

+14
-20
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ const insertData = {
247247
}
248248
};
249249

250-
client.insert(insertData, autoCreateColumns = true).then((resp) => {
250+
client.insert(insertData).then((resp) => {
251251
console.log(resp);
252252
}, (err) => {
253253
console.error(err);

src/errors.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class RequestIncorrectHttpError extends SlicingDiceError {
127127
}
128128
}
129129

130-
class RequestExceedLimitError extends SlicingDiceError {
130+
class RequestExceededLimitError extends SlicingDiceError {
131131
constructor(m) {
132132
super(m);
133133
}
@@ -231,7 +231,7 @@ class ColumnInvalidDescriptionError extends SlicingDiceError {
231231
}
232232
}
233233

234-
class ColumnExceedDescriptionlengthError extends SlicingDiceError {
234+
class ColumnExceededDescriptionlengthError extends SlicingDiceError {
235235
constructor(m) {
236236
super(m);
237237
}
@@ -352,7 +352,7 @@ class InsertColumnStringEmptyValueError extends SlicingDiceError {
352352
}
353353
}
354354

355-
class InsertColumnTimeseriesInvalidParameterError extends SlicingDiceError {
355+
class InsertColumnTimeSeriesInvalidParameterError extends SlicingDiceError {
356356
constructor(m) {
357357
super(m);
358358
}
@@ -364,7 +364,7 @@ class InsertColumnNumericInvalidValueError extends SlicingDiceError {
364364
}
365365
}
366366

367-
class InsertColumnTimeseriesMissingValueError extends SlicingDiceError {
367+
class InsertColumnTimeSeriesMissingValueError extends SlicingDiceError {
368368
constructor(m) {
369369
super(m);
370370
}
@@ -784,7 +784,7 @@ module.exports = {
784784
"RequestInvalidHttpMethodError": RequestInvalidHttpMethodError,
785785
"RequestInvalidEndpointError": RequestInvalidEndpointError,
786786
"RequestIncorrectHttpError": RequestIncorrectHttpError,
787-
"RequestExceedLimitError": RequestExceedLimitError,
787+
"RequestExceededLimitError": RequestExceededLimitError,
788788
// Account Errors (30 - 39)
789789
"AccountMissingPaymentMethodError": AccountMissingPaymentMethodError,
790790
"AccountPaymentRequiredError": AccountPaymentRequiredError,
@@ -803,7 +803,7 @@ module.exports = {
803803
"ColumnInvalidApiNameError": ColumnInvalidApiNameError,
804804
"ColumnInvalidNameError": ColumnInvalidNameError,
805805
"ColumnInvalidDescriptionError": ColumnInvalidDescriptionError,
806-
"ColumnExceedDescriptionlengthError": ColumnExceedDescriptionlengthError,
806+
"ColumnExceededDescriptionlengthError": ColumnExceededDescriptionlengthError,
807807
"ColumnInvalidCardinalityError": ColumnInvalidCardinalityError,
808808
"ColumnDecimalLimitError": ColumnDecimalLimitError,
809809
"ColumnRangeLimitError": ColumnRangeLimitError,
@@ -824,9 +824,9 @@ module.exports = {
824824
"InsertColumnLimitError": InsertColumnLimitError,
825825
"InsertDateFormatError": InsertDateFormatError,
826826
"InsertColumnStringEmptyValueError": InsertColumnStringEmptyValueError,
827-
"InsertColumnTimeseriesInvalidParameterError": InsertColumnTimeseriesInvalidParameterError,
827+
"InsertColumnTimeSeriesInvalidParameterError": InsertColumnTimeSeriesInvalidParameterError,
828828
"InsertColumnNumericInvalidValueError": InsertColumnNumericInvalidValueError,
829-
"InsertColumnTimeseriesMissingValueError": InsertColumnTimeseriesMissingValueError,
829+
"InsertColumnTimeSeriesMissingValueError": InsertColumnTimeSeriesMissingValueError,
830830
"QueryTimeSeriesInvalidPrecisionSecondsError": QueryTimeSeriesInvalidPrecisionSecondsError,
831831
"QueryTimeSeriesInvalidPrecisionMinutesError": QueryTimeSeriesInvalidPrecisionMinutesError,
832832
"QueryTimeSeriesInvalidPrecisionHoursError": QueryTimeSeriesInvalidPrecisionHoursError,

src/mappedErrors.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var mappedSDErrors = {
2121
25: errors["RequestInvalidHttpMethodError"],
2222
26: errors["RequestInvalidEndpointError"],
2323
27: errors["RequestIncorrectHttpError"],
24-
28: errors["RequestExceedLimitError"],
24+
28: errors["RequestExceededLimitError"],
2525
// Account Errors (30 - 39)
2626
30: errors["AccountMissingPaymentMethodError"],
2727
31: errors["AccountPaymentRequiredError"],
@@ -41,7 +41,7 @@ var mappedSDErrors = {
4141
49: errors["ColumnInvalidApiNameError"],
4242
50: errors["ColumnInvalidNameError"],
4343
51: errors["ColumnInvalidDescriptionError"],
44-
52: errors["ColumnExceedDescriptionlengthError"],
44+
52: errors["ColumnExceededDescriptionlengthError"],
4545
53: errors["ColumnInvalidCardinalityError"],
4646
54: errors["ColumnDecimalLimitError"],
4747
55: errors["ColumnRangeLimitError"],
@@ -62,9 +62,9 @@ var mappedSDErrors = {
6262
69: errors["InsertColumnLimitError"],
6363
70: errors["InsertDateFormatError"],
6464
71: errors["InsertColumnStringEmptyValueError"],
65-
72: errors["InsertColumnTimeseriesInvalidParameterError"],
65+
72: errors["InsertColumnTimeSeriesInvalidParameterError"],
6666
73: errors["InsertColumnNumericInvalidValueError"],
67-
74: errors["InsertColumnTimeseriesMissingValueError"],
67+
74: errors["InsertColumnTimeSeriesMissingValueError"],
6868
75: errors["QueryTimeSeriesInvalidPrecisionSecondsError"],
6969
76: errors["QueryTimeSeriesInvalidPrecisionMinutesError"],
7070
77: errors["QueryTimeSeriesInvalidPrecisionHoursError"],

src/slicer.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -497,14 +497,8 @@
497497
/* Send a insert command to the Slicing Dice API
498498
*
499499
* @param (array) query - the query to send to Slicing Dice API
500-
* @param (boolean) autoCreateColumns - if is true Slicing Dice API will
501-
* automatically create nonexistent columns
502500
*/
503-
insert(query, autoCreateColumns = false){
504-
if (autoCreateColumns){
505-
query["auto-create-columns"] = true
506-
}
507-
501+
insert(query){
508502
let path = this._sdRoutes.insert;
509503
return this.makeRequest({
510504
path: path,

0 commit comments

Comments
 (0)